generate snapshot in background #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcadiushmcts
force-pushed
the
dev/generate-snapshot-in-background
branch
7 times, most recently
from
575de73
to
1f65183
Compare
arcadiushmcts
force-pushed
the
dev/generate-snapshot-in-background
branch
from
1f65183
to
03bcb66
Compare
|
arcadiushmcts
requested review from
allanmckenzie,
santhosh-kumar3,
purple52 and
oktayekincioglu
| logger.debug("Stored successfully {}", storedSuccessfully); | ||
| return storedSuccessfully; | ||
| } catch (SerializationException e) { | ||
| logger.error("Error creating snapshot for %s".formatted(streamId), e); |
There was a problem hiding this comment.
Didn't know you could do this kind of formatting. Nice :-)
| @@ -26,7 +26,7 @@ public class AggregateSnapshotTest { | |||
| public void shouldCreateAnAggregateSnapshot() throws Exception { | |||
| final TestAggregate aggregate = new TestAggregate("STATE1"); | |||
|
|
|||
| final AggregateSnapshot<TestAggregate> snapshot = new AggregateSnapshot<>(STREAM_ID, VERSION_ID, aggregate); | |||
| final AggregateSnapshot<TestAggregate> snapshot = new AggregateSnapshot<>(STREAM_ID, VERSION_ID, aggregate, null); | |||
There was a problem hiding this comment.
I'm not sure I like passing in null like this. I've found nulls usually lead to tears and pain. Can this be an Optional instead?
| } | ||
|
|
||
| public AggregateSnapshot(final UUID streamId, final Long versionId, final String type, final byte[] aggregateByteRepresentation) { | ||
| public AggregateSnapshot(final UUID streamId, final Long versionId, final String type, final byte[] aggregateByteRepresentation, final ZonedDateTime createdAt) { |
There was a problem hiding this comment.
If the aggregateByteRepresentation byte array and createdAt date are linked, should they be but into a new single Object, AggregateByteArray or something. Also, if it's not always been created, should that Object be Optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.