Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing prefixes more elegantly #319

Open
albertmeronyo opened this issue Feb 12, 2021 · 2 comments
Open

Handle missing prefixes more elegantly #319

albertmeronyo opened this issue Feb 12, 2021 · 2 comments

Comments

@albertmeronyo
Copy link
Member

Currently we are just catching (thanks @c-martinez ) errors when the query uses undeclared prefixes. This is very common.

At the moment the backend fails silently, and simply no OpenAPI spec is rendered for the offending query prefixes. Using the UI to at least show some error (and suggestions for fixing) would be a great addition.

Another option would be to intelligently try to guess the prefix, by e.g. keeping a hard-coded list of common prefixes, issuing a request to prefix.cc, etc.

@albertmeronyo
Copy link
Member Author

There is now a warning about missing prefixes in #337

@c-martinez
Copy link
Collaborator

I don´t like the idea of intelligently guessing prefixes, because it changes the query behaviour. For example if you take the same query and run it directly against the SPARQL endpoint, you would get a different result. I don't think grlc should make such changes to queries.

Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants