Rename __USER_CAP* and *copy{in,out}cap* #2494
Open
+1,073
−1,021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions take the source or destintation address indirectly from
a potentially missaligned buffer. Rename them to refect this and to
free up the copy{in,out}ptr names.
Some of the code in question is dead code and doesn't or won't compile,
but I've changed it all for consistency.
NB: If the pointers are actually stored under aligned then this code is
broken with CHERI.
Rename the __USER_CAP macros to USER_PTR. This reflects our desire to talk about pointers when ever possible rather than capabilities.
Rename all variants of copy{in,out}cap to copy{in,out}ptr. This
reflects our desire to talk about pointers when ever possible rather
than capabilities.
bsdjhb
reviewed
Dec 8, 2025
Collaborator
bsdjhb
left a comment
bsdjhb
left a comment
There was a problem hiding this comment.
Generally looks good to me
| .Fn copyoutptr_nofault | ||
| functions must be used when copying data which may contain pointers and | ||
| they may be used anywhere, | ||
| but they should be used only when necessicary to limit the numeber of |
Collaborator
There was a problem hiding this comment.
Suggested change
| but they should be used only when necessicary to limit the numeber of | |
| but they should be used only when necessary to limit the number of |
| and | ||
| .Fn copyoutptr_nofault | ||
| functions must be used when copying data which may contain pointers and | ||
| they may be used anywhere, |
Collaborator
There was a problem hiding this comment.
I would be tempted to drop "and they may be used anywhere", and just say "must be used when copying data which contains pointers, but they should only be used when necessary..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__USER_CAP*and drop the__prefix following the model of PTRIN. (See RFC: rename __USER_CAP* to __USER_PTR*? #2485)