Custom CachyOS FISH configuration broken part of functonality

[va-al]

A problem description: There are minor cases when you need to delete some data from shell history due to security/privacy reasons. For this purpose there are history delete and history delete --contains or history delete --exact built-in commands in Fish. Although it doesn't work with CachyOS custom settings.

Expected behavior: history delete --contains $pattern interactively deletes from the history all $pattern matched records.

Actual behavior: The command only lists the recent history. As far as I can see by my tests ALL history's sub-commands are broken now (search, append, delete, etc).

The reason(if known):
The function redefined at /usr/share/cachyos-fish-config/cachyos-config.fish @ line 70.

function history builtin history --show-time='%F %T ' end

As far as I understood the "--show-time" modificator is only compatible with history listing.

Proposed solution:
Personally for me, I've disabled this hack. Although, it breaks down the native Fish functionality, so perhaps, it should be fixed Distro-wide somehow in new releases.

Proofs:

Extra details:

It's almost default Gnome based installation of CachyOS a couple weeks old.

[1Naim]

Sorry for taking so long to address this, this should be fixed with #21

[va-al]

I think it's a corner case which interested not to many people tho.
I've applied the changes manually and I'm not sure if it's better now.

For example the "history" command without any arguments doesn't work anymore.

And my initial problem haven't been fixed yet too. No error anymore, but it doesn't work too.

Is there more changes than the commit which I should apply?

[1Naim]

For example the "history" command without any arguments doesn't work anymore

Yeah, my mistake. I force pushed the branch. It should work now. Just remove the quotes basically.

[va-al]

Could you please elaborate which ones? if I delete the quotes around $argv it doesn't help. The same error. Although, I'm not sure if I do exactly what you meant.

[1Naim]

Check the PR again, it works for me now.

# Fish command history
function history
    builtin history --show-time='%F %T ' $argv
end

You need to restart your terminal for the changes to apply.

[va-al]

Ah, I'm sorry, my bad! I forgot to source the new config. I agree, "history" command without agrs works fine now.

Although, as of my case, it just has new error:

[1Naim]

Looking at it, it seems the default history is different compared to builtin history which is what the former is actually wrapping and expanding. I don't think we'll be changing this behaviour (cc @vnepogodin, @ptr1337), so if you want to keep using history delete --contains, you can't use our config.

[va-al]

Sure, thank you. I can manage this. I'm reporting just to highlight a possible problem to you, and let you to decide on behalf of the distro team what's better to keep as the default behavior. It's always a trade-off between features availability, I know.

[andretiagogr]

Those who, like me, want to restore the default history behavior can create a local config file to override the CachyOS function

echo "source /usr/share/fish/functions/history.fish" > ~/.config/fish/conf.d/default_history.fish