ci(jsonlint): add JSON linting (reanahub#301)

CameronMcClymont · CameronMcClymont · commit 798cf5fac305 · 2025-07-28T10:31:54.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -114,6 +114,20 @@ jobs:
           pip install check-manifest
           ./run-tests.sh --check-manifest
 
+  lint-jsonlint:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+
+      - name: Lint JSON files
+        run: |
+          npm install jsonlint --global
+          ./run-tests.sh --check-jsonlint
+
   format-shfmt:
     runs-on: ubuntu-24.04
     steps:
diff --git a/.release-please-config.json b/.release-please-config.json
@@ -5,9 +5,13 @@
     ".": {
       "changelog-sections": [
         { "type": "build", "section": "Build", "hidden": false },
-        { "type": "feat", "section": "Features", "hidden": false  },
+        { "type": "feat", "section": "Features", "hidden": false },
         { "type": "fix", "section": "Bug fixes", "hidden": false },
-        { "type": "perf", "section": "Performance improvements", "hidden": false },
+        {
+          "type": "perf",
+          "section": "Performance improvements",
+          "hidden": false
+        },
         { "type": "refactor", "section": "Code refactoring", "hidden": false },
         { "type": "style", "section": "Code style", "hidden": false },
         { "type": "test", "section": "Test suite", "hidden": false },
diff --git a/badges/v1.0/command_line_tool.json b/badges/v1.0/command_line_tool.json
@@ -1 +1 @@
-{"subject": "command_line_tool", "status": "86%", "color": "yellow"}
+{ "subject": "command_line_tool", "status": "86%", "color": "yellow" }
diff --git a/badges/v1.0/docker.json b/badges/v1.0/docker.json
@@ -1 +1 @@
-{"subject": "docker", "status": "62%", "color": "yellow"}
+{ "subject": "docker", "status": "62%", "color": "yellow" }
diff --git a/badges/v1.0/env_var.json b/badges/v1.0/env_var.json
@@ -1 +1 @@
-{"subject": "env_var", "status": "100%", "color": "green"}
+{ "subject": "env_var", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/expression_tool.json b/badges/v1.0/expression_tool.json
@@ -1 +1 @@
-{"subject": "expression_tool", "status": "100%", "color": "green"}
+{ "subject": "expression_tool", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/initial_work_dir.json b/badges/v1.0/initial_work_dir.json
@@ -1 +1 @@
-{"subject": "initial_work_dir", "status": "69%", "color": "yellow"}
+{ "subject": "initial_work_dir", "status": "69%", "color": "yellow" }
diff --git a/badges/v1.0/inline_javascript.json b/badges/v1.0/inline_javascript.json
@@ -1 +1 @@
-{"subject": "inline_javascript", "status": "94%", "color": "yellow"}
+{ "subject": "inline_javascript", "status": "94%", "color": "yellow" }
diff --git a/badges/v1.0/multiple_input.json b/badges/v1.0/multiple_input.json
@@ -1 +1 @@
-{"subject": "multiple_input", "status": "100%", "color": "green"}
+{ "subject": "multiple_input", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/required.json b/badges/v1.0/required.json
@@ -1 +1 @@
-{"subject": "required", "status": "94%", "color": "red"}
+{ "subject": "required", "status": "94%", "color": "red" }
diff --git a/badges/v1.0/resource.json b/badges/v1.0/resource.json
@@ -1 +1 @@
-{"subject": "resource", "status": "100%", "color": "green"}
+{ "subject": "resource", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/scatter.json b/badges/v1.0/scatter.json
@@ -1 +1 @@
-{"subject": "scatter", "status": "100%", "color": "green"}
+{ "subject": "scatter", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/schema_def.json b/badges/v1.0/schema_def.json
@@ -1 +1 @@
-{"subject": "schema_def", "status": "100%", "color": "green"}
+{ "subject": "schema_def", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/shell_command.json b/badges/v1.0/shell_command.json
@@ -1 +1 @@
-{"subject": "shell_command", "status": "75%", "color": "yellow"}
+{ "subject": "shell_command", "status": "75%", "color": "yellow" }
diff --git a/badges/v1.0/step_input.json b/badges/v1.0/step_input.json
@@ -1 +1 @@
-{"subject": "step_input", "status": "100%", "color": "green"}
+{ "subject": "step_input", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/step_input_expression.json b/badges/v1.0/step_input_expression.json
@@ -1 +1 @@
-{"subject": "step_input_expression", "status": "100%", "color": "green"}
+{ "subject": "step_input_expression", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/subworkflow.json b/badges/v1.0/subworkflow.json
@@ -1 +1 @@
-{"subject": "subworkflow", "status": "100%", "color": "green"}
+{ "subject": "subworkflow", "status": "100%", "color": "green" }
diff --git a/badges/v1.0/workflow.json b/badges/v1.0/workflow.json
@@ -1 +1 @@
-{"subject": "workflow", "status": "98%", "color": "yellow"}
+{ "subject": "workflow", "status": "98%", "color": "yellow" }
diff --git a/badges/v1.1/command_line_tool.json b/badges/v1.1/command_line_tool.json
@@ -1 +1 @@
-{"subject": "command_line_tool", "status": "78%", "color": "yellow"}
+{ "subject": "command_line_tool", "status": "78%", "color": "yellow" }
diff --git a/badges/v1.1/docker.json b/badges/v1.1/docker.json
@@ -1 +1 @@
-{"subject": "docker", "status": "60%", "color": "yellow"}
+{ "subject": "docker", "status": "60%", "color": "yellow" }
diff --git a/badges/v1.1/env_var.json b/badges/v1.1/env_var.json
@@ -1 +1 @@
-{"subject": "env_var", "status": "100%", "color": "green"}
+{ "subject": "env_var", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/expression_tool.json b/badges/v1.1/expression_tool.json
@@ -1 +1 @@
-{"subject": "expression_tool", "status": "100%", "color": "green"}
+{ "subject": "expression_tool", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/format_checking.json b/badges/v1.1/format_checking.json
@@ -1 +1 @@
-{"subject": "format_checking", "status": "0%", "color": "yellow"}
+{ "subject": "format_checking", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.1/initial_work_dir.json b/badges/v1.1/initial_work_dir.json
@@ -1 +1 @@
-{"subject": "initial_work_dir", "status": "73%", "color": "yellow"}
+{ "subject": "initial_work_dir", "status": "73%", "color": "yellow" }
diff --git a/badges/v1.1/inline_javascript.json b/badges/v1.1/inline_javascript.json
@@ -1 +1 @@
-{"subject": "inline_javascript", "status": "92%", "color": "yellow"}
+{ "subject": "inline_javascript", "status": "92%", "color": "yellow" }
diff --git a/badges/v1.1/inplace_update.json b/badges/v1.1/inplace_update.json
@@ -1 +1 @@
-{"subject": "inplace_update", "status": "0%", "color": "yellow"}
+{ "subject": "inplace_update", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.1/input_object_requirements.json b/badges/v1.1/input_object_requirements.json
@@ -1 +1 @@
-{"subject": "input_object_requirements", "status": "0%", "color": "yellow"}
+{ "subject": "input_object_requirements", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.1/multiple_input.json b/badges/v1.1/multiple_input.json
@@ -1 +1 @@
-{"subject": "multiple_input", "status": "100%", "color": "green"}
+{ "subject": "multiple_input", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/networkaccess.json b/badges/v1.1/networkaccess.json
@@ -1 +1 @@
-{"subject": "networkaccess", "status": "50%", "color": "yellow"}
+{ "subject": "networkaccess", "status": "50%", "color": "yellow" }
diff --git a/badges/v1.1/required.json b/badges/v1.1/required.json
@@ -1 +1 @@
-{"subject": "required", "status": "84%", "color": "red"}
+{ "subject": "required", "status": "84%", "color": "red" }
diff --git a/badges/v1.1/resource.json b/badges/v1.1/resource.json
@@ -1 +1 @@
-{"subject": "resource", "status": "88%", "color": "yellow"}
+{ "subject": "resource", "status": "88%", "color": "yellow" }
diff --git a/badges/v1.1/scatter.json b/badges/v1.1/scatter.json
@@ -1 +1 @@
-{"subject": "scatter", "status": "100%", "color": "green"}
+{ "subject": "scatter", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/schema_def.json b/badges/v1.1/schema_def.json
@@ -1 +1 @@
-{"subject": "schema_def", "status": "100%", "color": "green"}
+{ "subject": "schema_def", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/shell_command.json b/badges/v1.1/shell_command.json
@@ -1 +1 @@
-{"subject": "shell_command", "status": "76%", "color": "yellow"}
+{ "subject": "shell_command", "status": "76%", "color": "yellow" }
diff --git a/badges/v1.1/step_input.json b/badges/v1.1/step_input.json
@@ -1 +1 @@
-{"subject": "step_input", "status": "100%", "color": "green"}
+{ "subject": "step_input", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/step_input_expression.json b/badges/v1.1/step_input_expression.json
@@ -1 +1 @@
-{"subject": "step_input_expression", "status": "100%", "color": "green"}
+{ "subject": "step_input_expression", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/subworkflow.json b/badges/v1.1/subworkflow.json
@@ -1 +1 @@
-{"subject": "subworkflow", "status": "100%", "color": "green"}
+{ "subject": "subworkflow", "status": "100%", "color": "green" }
diff --git a/badges/v1.1/timelimit.json b/badges/v1.1/timelimit.json
@@ -1 +1 @@
-{"subject": "timelimit", "status": "44%", "color": "yellow"}
+{ "subject": "timelimit", "status": "44%", "color": "yellow" }
diff --git a/badges/v1.1/workflow.json b/badges/v1.1/workflow.json
@@ -1 +1 @@
-{"subject": "workflow", "status": "95%", "color": "yellow"}
+{ "subject": "workflow", "status": "95%", "color": "yellow" }
diff --git a/badges/v1.2/command_line_tool.json b/badges/v1.2/command_line_tool.json
@@ -1 +1 @@
-{"subject": "command_line_tool", "status": "70%", "color": "yellow"}
+{ "subject": "command_line_tool", "status": "70%", "color": "yellow" }
diff --git a/badges/v1.2/conditional.json b/badges/v1.2/conditional.json
@@ -1 +1 @@
-{"subject": "conditional", "status": "60%", "color": "yellow"}
+{ "subject": "conditional", "status": "60%", "color": "yellow" }
diff --git a/badges/v1.2/docker.json b/badges/v1.2/docker.json
@@ -1 +1 @@
-{"subject": "docker", "status": "70%", "color": "yellow"}
+{ "subject": "docker", "status": "70%", "color": "yellow" }
diff --git a/badges/v1.2/env_var.json b/badges/v1.2/env_var.json
@@ -1 +1 @@
-{"subject": "env_var", "status": "100%", "color": "green"}
+{ "subject": "env_var", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/expression_tool.json b/badges/v1.2/expression_tool.json
@@ -1 +1 @@
-{"subject": "expression_tool", "status": "100%", "color": "green"}
+{ "subject": "expression_tool", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/format_checking.json b/badges/v1.2/format_checking.json
@@ -1 +1 @@
-{"subject": "format_checking", "status": "0%", "color": "yellow"}
+{ "subject": "format_checking", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.2/initial_work_dir.json b/badges/v1.2/initial_work_dir.json
@@ -1 +1 @@
-{"subject": "initial_work_dir", "status": "31%", "color": "yellow"}
+{ "subject": "initial_work_dir", "status": "31%", "color": "yellow" }
diff --git a/badges/v1.2/inline_javascript.json b/badges/v1.2/inline_javascript.json
@@ -1 +1 @@
-{"subject": "inline_javascript", "status": "83%", "color": "yellow"}
+{ "subject": "inline_javascript", "status": "83%", "color": "yellow" }
diff --git a/badges/v1.2/inplace_update.json b/badges/v1.2/inplace_update.json
@@ -1 +1 @@
-{"subject": "inplace_update", "status": "0%", "color": "yellow"}
+{ "subject": "inplace_update", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.2/input_object_requirements.json b/badges/v1.2/input_object_requirements.json
@@ -1 +1 @@
-{"subject": "input_object_requirements", "status": "0%", "color": "yellow"}
+{ "subject": "input_object_requirements", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.2/multiple.json b/badges/v1.2/multiple.json
@@ -1 +1 @@
-{"subject": "multiple", "status": "0%", "color": "yellow"}
+{ "subject": "multiple", "status": "0%", "color": "yellow" }
diff --git a/badges/v1.2/multiple_input.json b/badges/v1.2/multiple_input.json
@@ -1 +1 @@
-{"subject": "multiple_input", "status": "70%", "color": "yellow"}
+{ "subject": "multiple_input", "status": "70%", "color": "yellow" }
diff --git a/badges/v1.2/networkaccess.json b/badges/v1.2/networkaccess.json
@@ -1 +1 @@
-{"subject": "networkaccess", "status": "50%", "color": "yellow"}
+{ "subject": "networkaccess", "status": "50%", "color": "yellow" }
diff --git a/badges/v1.2/required.json b/badges/v1.2/required.json
@@ -1 +1 @@
-{"subject": "required", "status": "84%", "color": "red"}
+{ "subject": "required", "status": "84%", "color": "red" }
diff --git a/badges/v1.2/resource.json b/badges/v1.2/resource.json
@@ -1 +1 @@
-{"subject": "resource", "status": "90%", "color": "yellow"}
+{ "subject": "resource", "status": "90%", "color": "yellow" }
diff --git a/badges/v1.2/scatter.json b/badges/v1.2/scatter.json
@@ -1 +1 @@
-{"subject": "scatter", "status": "81%", "color": "yellow"}
+{ "subject": "scatter", "status": "81%", "color": "yellow" }
diff --git a/badges/v1.2/schema_def.json b/badges/v1.2/schema_def.json
@@ -1 +1 @@
-{"subject": "schema_def", "status": "100%", "color": "green"}
+{ "subject": "schema_def", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/secondary_files.json b/badges/v1.2/secondary_files.json
@@ -1 +1 @@
-{"subject": "secondary_files", "status": "50%", "color": "yellow"}
+{ "subject": "secondary_files", "status": "50%", "color": "yellow" }
diff --git a/badges/v1.2/shell_command.json b/badges/v1.2/shell_command.json
@@ -1 +1 @@
-{"subject": "shell_command", "status": "76%", "color": "yellow"}
+{ "subject": "shell_command", "status": "76%", "color": "yellow" }
diff --git a/badges/v1.2/step_input.json b/badges/v1.2/step_input.json
@@ -1 +1 @@
-{"subject": "step_input", "status": "100%", "color": "green"}
+{ "subject": "step_input", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/step_input_expression.json b/badges/v1.2/step_input_expression.json
@@ -1 +1 @@
-{"subject": "step_input_expression", "status": "100%", "color": "green"}
+{ "subject": "step_input_expression", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/subworkflow.json b/badges/v1.2/subworkflow.json
@@ -1 +1 @@
-{"subject": "subworkflow", "status": "100%", "color": "green"}
+{ "subject": "subworkflow", "status": "100%", "color": "green" }
diff --git a/badges/v1.2/timelimit.json b/badges/v1.2/timelimit.json
@@ -1 +1 @@
-{"subject": "timelimit", "status": "44%", "color": "yellow"}
+{ "subject": "timelimit", "status": "44%", "color": "yellow" }
diff --git a/badges/v1.2/workflow.json b/badges/v1.2/workflow.json
@@ -1 +1 @@
-{"subject": "workflow", "status": "95%", "color": "yellow"}
+{ "subject": "workflow", "status": "95%", "color": "yellow" }
diff --git a/run-tests.sh b/run-tests.sh
@@ -79,6 +79,10 @@ check_docker_build() {
     docker build -t docker.io/reanahub/reana-workflow-engine-cwl .
 }
 
+check_jsonlint() {
+    find . -name "*.json" -exec jsonlint -q {} \+
+}
+
 check_shfmt() {
     shfmt -d .
 }
@@ -94,6 +98,7 @@ check_all() {
     check_pytest
     check_dockerfile
     check_docker_build
+    check_jsonlint
     check_shfmt
 }
 
@@ -114,6 +119,7 @@ case $arg in
 --check-pytest) check_pytest ;;
 --check-dockerfile) check_dockerfile ;;
 --check-docker-build) check_docker_build ;;
+--check-jsonlint) check_jsonlint ;;
 --check-shfmt) check_shfmt ;;
 --check-all) check_all ;;
 *) echo "[ERROR] Invalid argument '$arg'. Exiting." && exit 1 ;;

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "command_line_tool", "status": "86%", "color": "yellow"}`
	`1`	`+{ "subject": "command_line_tool", "status": "86%", "color": "yellow" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "docker", "status": "62%", "color": "yellow"}`
	`1`	`+{ "subject": "docker", "status": "62%", "color": "yellow" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "env_var", "status": "100%", "color": "green"}`
	`1`	`+{ "subject": "env_var", "status": "100%", "color": "green" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "expression_tool", "status": "100%", "color": "green"}`
	`1`	`+{ "subject": "expression_tool", "status": "100%", "color": "green" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "initial_work_dir", "status": "69%", "color": "yellow"}`
	`1`	`+{ "subject": "initial_work_dir", "status": "69%", "color": "yellow" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "inline_javascript", "status": "94%", "color": "yellow"}`
	`1`	`+{ "subject": "inline_javascript", "status": "94%", "color": "yellow" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "multiple_input", "status": "100%", "color": "green"}`
	`1`	`+{ "subject": "multiple_input", "status": "100%", "color": "green" }`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"subject": "required", "status": "94%", "color": "red"}`
	`1`	`+{ "subject": "required", "status": "94%", "color": "red" }`