Update contents to highlight SE-0335 and SE-0352

Author: maximkrouk

ACKNOWLEDGMENTS.md

@@ -1,3 +1,11 @@
 Initially I was challenged with the idea of creating AnyView from Any by https://github.com/glukianets at the end of 2k22.
 
-It was fun, I successfully passed the challenge, and now I challenge u, my reader, to implement similar thing without use of `_openExistential` (it is possible tho even more tricky) 😎
+It was fun, I successfully passed the challenge, and now I challenge u, my reader, to implement similar thing without use of `_openExistential` (it is possible using tho even more tricky) 😎
+
+> [!TIP]
+>
+> - Imagine it's Swift 5.0
+>
+>   - You can't use SE-0335 ( `any View`)
+>
+>   - You should use `unsafeBitCast`

Makefile

@@ -1,5 +1,3 @@
-CONFIG = Debug
-
 DERIVED_DATA_PATH = ~/.derivedData/$(CONFIG)
 
 PLATFORM_IOS = iOS Simulator,id=$(call udid_for,iOS,iPhone \d\+ Pro [^M])
@@ -9,57 +7,135 @@ PLATFORM_TVOS = tvOS Simulator,id=$(call udid_for,tvOS,TV)
 PLATFORM_VISIONOS = visionOS Simulator,id=$(call udid_for,visionOS,Vision)
 PLATFORM_WATCHOS = watchOS Simulator,id=$(call udid_for,watchOS,Watch)
 
-PLATFORM = IOS
-DESTINATION = platform="$(PLATFORM_$(PLATFORM))"
+ifeq ($(PLATFORM),iOS)
+	DESTINATION = "$(PLATFORM_IOS)"
+else ifeq ($(PLATFORM),macOS)
+	DESTINATION = "$(PLATFORM_MACOS)"
+else ifeq ($(PLATFORM),tvOS)
+	DESTINATION = "$(PLATFORM_TVOS)"
+else ifeq ($(PLATFORM),watchOS)
+	DESTINATION = "$(PLATFORM_WATCHOS)"
+else ifeq ($(PLATFORM),visionOS)
+	DESTINATION = "$(PLATFORM_VISIONOS)"
+else ifeq ($(PLATFORM),macCatalyst)
+	DESTINATION = "$(PLATFORM_MAC_CATALYST)"
+else
+	DESTINATION = __unsupported__
+endif
 
 PLATFORM_ID = $(shell echo "$(DESTINATION)" | sed -E "s/.+,id=(.+)/\1/")
 
-WORKSPACE = Package.xcworkspace
-SCHEME = swift-existential-container
+SCHEME = Unspecified
+WORKSPACE = ".swiftpm/xcode/package.xcworkspace"
 
-XCODEBUILD_ARGUMENT = test
+ifeq ($(BEAUTIFY),true)
+	XCBEAUTIFY = xcbeautify
+	XCBEAUTIFY_COMMAND = xcbeautify
+else ifeq ($(BEAUTIFY),quiet)
+	XCBEAUTIFY = xcbeautify
+	XCBEAUTIFY_COMMAND = xcbeautify --quiet
+else
+	XCBEAUTIFY = __do_not_beautify__
+endif
 
 XCODEBUILD_FLAGS = \
 	-configuration $(CONFIG) \
 	-derivedDataPath $(DERIVED_DATA_PATH) \
-	-destination $(DESTINATION) \
+	-destination=$(DESTINATION) \
 	-scheme "$(SCHEME)" \
 	-skipMacroValidation \
 	-workspace $(WORKSPACE)
 
-XCODEBUILD_COMMAND = xcodebuild $(XCODEBUILD_ARGUMENT) $(XCODEBUILD_FLAGS)
+XCODEBUILD_COMMAND = xcodebuild $(COMMAND) $(XCODEBUILD_FLAGS)
 
-ifneq ($(strip $(shell which xcbeautify)),)
-	XCODEBUILD = set -o pipefail && $(XCODEBUILD_COMMAND) | xcbeautify --quiet
+ifneq ($(strip $(shell which $(XCBEAUTIFY))),)
+	XCODEBUILD = set -o pipefail && $(XCODEBUILD_COMMAND) | $(XCBEAUTIFY_COMMAND)
 else
 	XCODEBUILD = $(XCODEBUILD_COMMAND)
 endif
 
 TEST_RUNNER_CI = $(CI)
 
 warm-simulator:
+	@echo "Running warm-simulator for $(PLATFORM)"
 	@test "$(PLATFORM_ID)" != "" \
 		&& xcrun simctl boot $(PLATFORM_ID) \
 		&& open -a Simulator --args -CurrentDeviceUDID $(PLATFORM_ID) \
 		|| exit 0
 
 xcodebuild: warm-simulator
+	@echo "Running xcodebuild for $(PLATFORM)"
+	@echo "  Workspace: $(WORKSPACE)"
+	@echo "  Scheme: $(SCHEME)"
+	@echo "  Config: $(CONFIG)"
+	@echo "  Destination: $(DESTINATION)"
+	@echo "  DerivedData: $(DERIVED_DATA_PATH)"
 	$(XCODEBUILD)
 
 # Workaround for debugging Swift Testing tests: https://github.com/cpisciotta/xcbeautify/issues/313
 xcodebuild-raw: warm-simulator
+	@echo "Running xcodebuild-raw for $(PLATFORM)"
+	@echo "  Workspace: $(WORKSPACE)"
+	@echo "  Scheme: $(SCHEME)"
+	@echo "  Config: $(CONFIG)"
+	@echo "  Destination: $(DESTINATION)"
+	@echo "  DerivedData: $(DERIVED_DATA_PATH)"
 	$(XCODEBUILD_COMMAND)
 
 build-for-library-evolution:
+	@echo "Running build-for-library-evolution for $(SCHEME)"
 	swift build \
 		-q \
 		-c release \
-		--target "$(SCHEME)" \
+		--target ${SCHEME} \
 		-Xswiftc -emit-module-interface \
 		-Xswiftc -enable-library-evolution
 
-.PHONY: build-for-library-evolution format warm-simulator xcodebuild xcodebuild-raw
+benchmark:
+	@echo "Running benchmark for $(SCHEME)"
+	swift run --configuration release $(SCHEME)
+
+swift-format:
+	@echo "Running swift-format"
+	find . \
+		-path '*/Documentation.docc' -prune -o \
+		-name '*.swift' \
+		-not -path '*/.*' -print0 \
+		| xargs -0 swift format --ignore-unparsable-files --in-place
+
+DOC_WARNINGS = $(shell \
+	xcodebuild clean docbuild \
+		-scheme "$(SCHEME)" \
+		-destination platform="$(DESTINATION)" \
+		-quiet 2>&1 \
+		| grep "couldn't be resolved to known documentation" \
+		| sed 's|$(PWD)|.|g' \
+		| tr '\n' '\1' \
+)
+
+test-docs:
+	@echo "Running test-docs for $(SCHEME) [$(PLATFORM)]"
+	@test "$(DOC_WARNINGS)" = "" \
+		|| (echo "xcodebuild docbuild failed:\n\n$(DOC_WARNINGS)" | tr '\1' '\n' \
+		&& exit 1)
+
+github-build-docs:
+	@echo "Running github-build-docs for $(SCHEME)"
+	@chmod +x '.scripts/github-build-docs'
+	SCHEME=$(SCHEME) ./.scripts/github-build-docs
+
+.PHONY: build-for-library-evolution format warm-simulator xcodebuild xcodebuild-raw test-docs
 
 define udid_for
-$(shell xcrun simctl list devices available '$(1)' | grep '$(2)' | sort -r | head -1 | awk -F '[()]' '{ print $$(NF-3) }')
+$(shell \
+	xcrun simctl list devices available '$(1)' \
+	| grep '$(2)' \
+	| sort -r \
+	| head -1 \
+	| awk -F '[()]' '{ print $$(NF-3) }' \
+)
 endef
+
+# simple action for testing if Makefile is valid
+ping:
+	@echo "pong 🏓"

README.md

@@ -1,8 +1,9 @@
 # swift-existential-container
 
-[![CI](https://github.com/CaptureContext/swift-existential-container/actions/workflows/ci.yml/badge.svg)](https://github.com/CaptureContext/swift-existential-container/actions/workflows/ci.yml) [![SwiftPM 5.6](https://img.shields.io/badge/swiftpm-6.0-ED523F.svg?style=flat)](https://swift.org/download/) ![Platforms](https://img.shields.io/badge/platforms-all-ED523F.svg?style=flat) [![@capture_context](https://img.shields.io/badge/contact-@capture__context-1DA1F2.svg?style=flat&logo=twitter)](https://twitter.com/capture_context) 
+[![CI](https://github.com/CaptureContext/swift-existential-container/actions/workflows/ci.yml/badge.svg)](https://github.com/CaptureContext/swift-existential-container/actions/workflows/ci.yml) [![SwiftPM 6.0](https://img.shields.io/badge/swiftpm-6.0-ED523F.svg?style=flat)](https://swift.org/download/) ![Platforms](https://img.shields.io/badge/platforms-all-ED523F.svg?style=flat) [![@capture_context](https://img.shields.io/badge/contact-@capture__context-1DA1F2.svg?style=flat&logo=twitter)](https://twitter.com/capture_context) 
 
-Package for opening existentials with ease.
+> [!NOTE]
+> _You don't need this package or explicit `_openExistential` now, because [SE-0352](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0352-implicit-open-existentials.md) introduced implicit open existentials and any of examples can be acheived with plain generic functions that now can open existentials implicitly. Example with AnyView can be simplified even more with [SE-0335](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0335-existential-any.md)_ 💁‍♂️
 
 ## Usage
 
@@ -89,6 +90,38 @@ extension AnyView {
 }
 ```
 
+### [SE-0352](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0352-implicit-open-existentials.md)
+
+```swift
+extension AnyView {
+  @MainActor
+  init?(any: Any) {
+    func open<T: View>(_ view: T) -> AnyView { .init(view) }
+    guard let anyView = any as? (any View) else { return nil }
+    self = open(anyView)
+  }
+}
+```
+
+### [SE-0335](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0335-existential-any.md)
+
+```swift
+extension View {
+  fileprivate func eraseToAnyView() -> AnyView { AnyView(self) }
+}
+```
+
+It's enough, but the call site will look like this `(anyValue as? (any View))?.eraseToAnyView()` which is not very ergonomic and you may still want an AnyView extension
+
+```swift
+extension AnyView {
+  @MainActor
+  init?(any: Any) {
+    guard let anyView = any as? (any View) else { return nil }
+    self = anyView.eraseToAnyView()
+  }
+}
+```
 
 ### APIs
 
@@ -132,7 +165,7 @@ If you use SwiftPM for your project structure, add ExistentialContainer to your
 ```swift
 .package(
   url: "[email protected]:capturecontext/swift-existential-container.git", 
-  .upToNextMinor(from: "1.0.0")
+  .upToNextMajor(from: "1.0.1")
 )
 ```
 
@@ -141,7 +174,7 @@ or via HTTPS
 ```swift
 .package(
   url: "https://github.com:capturecontext/swift-existential-container.git", 
-  .upToNextMinor("1.0.0")
+  .upToNextMajor("1.0.1")
 )
 ```
 

Tests/ExistentialContainerTests/ExistentialContainerTests.swift

@@ -14,8 +14,24 @@ struct ExistentialContainerTests {
 		let anyText: Any = text
 		#expect(AnyView(any: anyText) != nil)
 	}
-	#endif
 
+	@MainActor
+	@Test
+	func testSwiftUIAnyViewSE0352() async throws {
+		let text = Text("")
+		let anyText: Any = text
+		#expect(AnyView(anySE0352: anyText) != nil)
+	}
+
+	@MainActor
+	@Test
+	func testSwiftUIAnyViewSE0335() async throws {
+		let text = Text("")
+		let anyText: Any = text
+		let anyView: AnyView? = (anyText as? (any View))?.__eraseToAnyViewSE0335()
+		#expect(anyView != nil)
+	}
+	#endif
 
 	@Test
 	func testMutuallyDependantTypes() async throws {
@@ -29,6 +45,32 @@ struct ExistentialContainerTests {
 
 		#expect(component.model === model)
 	}
+
+	@Test
+	func testMutuallyDependantTypesSE0352() async throws {
+		let component = SomeComponent()
+		let model = SomeComponent.Model()
+
+		let anyComponent: any UIComponent = component
+		let anyModel: any UIComponentModel = model
+
+		setAnyModelSE0352(anyModel, to: anyComponent)
+
+		#expect(component.model === model)
+	}
+
+	@Test
+	func testMutuallyDependantTypesSE0335() async throws {
+		let component = SomeComponent()
+		let model = SomeComponent.Model()
+
+		let anyComponent: any UIComponent = component
+		let anyModel: any UIComponentModel = model
+
+		anyComponent.setAnyModelSE0335(anyModel)
+
+		#expect(component.model === model)
+	}
 }
 
 private final class SomeComponent: UIComponent {

Tests/ExistentialContainerTests/Helpers/AnyView+.swift

@@ -18,4 +18,29 @@ extension AnyView {
 	}
 }
 
+// MARK: - SE-0352
+
+extension AnyView {
+	@MainActor
+	init?(anySE0352 any: Any) {
+		func open<T: View>(_ view: T) -> AnyView { .init(view) }
+		guard let anyView = any as? (any View) else { return nil }
+		self = open(anyView)
+	}
+}
+
+// MARK: - SE-0335
+
+extension AnyView {
+	@MainActor
+	init?(anySE0335 any: Any) {
+		guard let anyView = any as? (any View) else { return nil }
+		self = anyView.__eraseToAnyViewSE0335()
+	}
+}
+
+private extension View {
+	func __eraseToAnyViewSE0335() -> AnyView { .init(self) }
+}
+
 #endif

Tests/ExistentialContainerTests/Helpers/UIComponent+.swift

@@ -15,3 +15,23 @@ extension ExistentialBox<(any UIComponent)> {
 		ExistentialBox<UIComponentConforming>.open(content) { $0.setAnyModel(model) }
 	}
 }
+
+// MARK: - SE-0352
+
+func setAnyModelSE0352<
+	Component: UIComponent,
+	Model: UIComponentModel
+>(
+	_ model: Model,
+	to component: Component
+) {
+	(model as? Component.Model).map(component.setModel)
+}
+
+// MARK: - SE-0335
+
+extension UIComponent {
+	func setAnyModelSE0335(_ model: any UIComponentModel) {
+		(model as? Model).map(setModel)
+	}
+}