Skip to content

Remove duplicates of the ProtocolIDs #636

@Valera56pub

Description

@Valera56pub

Guideline

  1. Carefully read the issue description before applying to ensure you have all the necessary information to start working on it.
  2. Write a brief description of how you will approach the task (without using ChatGPT).
  3. Add your Telegram handler in your application (e.g., in OnlyDust or similar)
  4. Write ETA in your application

What should I do if I have a problem

  1. Try to google it before asking. Googling is taking major part of dev work
  2. If you couldn't find answer your question with Google, text your question to dev group with your question.
  3. Do not send DM to maintainer, it would be better and faster to ask other contributors in chat

How to prepare PR

  1. Check if your code smell good
  2. Add close # to link your issue with your PR
  3. Do not commit changes which is not related to your task
  4. Check after you created PR, if you committed everything.

Task description

  1. Search for class ProtocolIDs - You can see a few duplicates.
  2. The correct version of the ProtocolIDs is:
class ProtocolIDs(Enum):
    HASHSTACK: str = "Hashstack"
    NOSTRA_ALPHA: str = "Nostra_alpha"
    NOSTRA_MAINNET: str = "Nostra_mainnet"
    ZKLEND: str = "zkLend"
    VESU:str = "Vesu"
  1. Move ProtocolIDs into the shared folder. Remove duplicates and update ALL imports.

NOTE: ignore sdk web_app legacy_app

Metadata

Metadata

Labels

onlydust-waveContribute to awesome OSS repos during OnlyDust's open source week

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions