Fix wrong title shown in window menu, iina#4229

This commit will remove the check that suppressed the workaround in
MainWindowController.windowWillOpen for the title problem when running
under macOS 12+.

The workaround was conditionalized because AppKit was confirmed to be
working correctly under macOS 12.3. The assumption was that we could
count of AppKit working correctly going forward. However the problem
is back in macOS 13.2.1. Not clear when it was re-introduced.

Author: low-batt

Diff for: iina/MainWindowController.swift

@@ -1052,26 +1052,20 @@ class MainWindowController: PlayerWindowController {
   // MARK: - Window delegate: Open / Close
 
   func windowWillOpen() {
-    if #available(macOS 12, *) {
-      // Apparently Apple fixed AppKit for Monterey so the workaround below is only needed for
-      // previous versions of macOS. Support for #unavailable is coming in Swift 5.6. The version of
-      // Xcode being used at the time of this writing supports Swift 5.5.
-    } else {
-      // Must workaround an AppKit defect in earlier versions of macOS. This defect is known to
-      // exist in Catalina and Big Sur. The problem was not reproducible in Monterey. The status of
-      // other versions of macOS is unknown, however the workaround should be safe to apply in any
-      // version of macOS. The problem was reported in issues #3159, #3097 and #3253. The titles of
-      // open windows shown in the "Window" menu are automatically managed by the AppKit framework.
-      // To improve performance PlayerCore caches and reuses player instances along with their
-      // windows. This technique is valid and recommended by Apple. But in older versions of macOS,
-      // if a window is reused the framework will display the title first used for the window in the
-      // "Window" menu even after IINA has updated the title of the window. This problem can also be
-      // seen when right-clicking or control-clicking the IINA icon in the dock. As a workaround
-      // reset the window's title to "Window" before it is reused. This is the default title AppKit
-      // assigns to a window when it is first created. Surprising and rather disturbing this works
-      // as a workaround, but it does.
-      window!.title = "Window"
-    }
+    // Must workaround an AppKit defect in some versions of macOS. This defect is known to exist in
+    // Catalina and Big Sur. The problem was not reproducible in early versions of Monterey. It
+    // reappeared in Ventura. The status of other versions of macOS is unknown, however the
+    // workaround should be safe to apply in any version of macOS. The problem was reported in
+    // issues #4229, #3159, #3097 and #3253. The titles of open windows shown in the "Window" menu
+    // are automatically managed by the AppKit framework. To improve performance PlayerCore caches
+    // and reuses player instances along with their windows. This technique is valid and recommended
+    // by Apple. But in some versions of macOS, if a window is reused the framework will display the
+    // title first used for the window in the "Window" menu even after IINA has updated the title of
+    // the window. This problem can also be seen when right-clicking or control-clicking the IINA
+    // icon in the dock. As a workaround reset the window's title to "Window" before it is reused.
+    // This is the default title AppKit assigns to a window when it is first created. Surprising and
+    // rather disturbing this works as a workaround, but it does.
+    window!.title = "Window"
 
     // As there have been issues in this area, log details about the screen selection process.
     NSScreen.log("window!.screen", window!.screen)