Skip to content

An interrupted flight means the next flight will start part way through #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kring opened this issue Nov 21, 2024 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kring
Copy link
Member

kring commented Nov 21, 2024

Reported here:
https://community.cesium.com/t/about-currentflytotime-in-cesiumflytocontroller/36701

When a CesiumFlyController flight completes, the _currentFlyToTime is reset to zero:
https://github.com/CesiumGS/cesium-unity/blob/v1.13.1/Runtime/CesiumFlyToController.cs#L312

But if the flight is interrupted, it is not:
https://github.com/CesiumGS/cesium-unity/blob/v1.13.1/Runtime/CesiumFlyToController.cs#L329

Starting a new flight also, surprisingly, does not reset _currentFlyToTime to zero, either. So as a result, an interrupted flight means that the next flight begins at whatever _currentFlyToTime the previous one was interrupted at.

@kring kring added the bug Something isn't working label Nov 21, 2024
@j9liu j9liu added the good first issue Good for newcomers label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants