576 triangle fan indexing is wrong #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e switch to make POINTS the default instead of TRIANGLE_FAN.
Formatting.
j9liu
requested changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks @david-lively ! The fix looks great, just one ask about the changelog entry. Otherwise this should be good to go!
j9liu
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks @david-lively! I just tweaked the wording a bit to avoid bothering you about it again. Looking to merge once CI passes. ✌️
|
Merging now. Congrats on your first PR @david-lively !! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of fix for Unreal
This PR adds support for
TRIANGLE_FANprimitives.Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.[ ] I have updated the documentation as necessary.Testing plan
Test that this tileset loads (best viewed under a "True Origin" georeference): MeshPrimitiveModes.zip.
There should be a row of three hexagons.
