Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of observability in Forest Message Pool #4898

Open
4 tasks
elmattic opened this issue Oct 15, 2024 · 0 comments
Open
4 tasks

Lack of observability in Forest Message Pool #4898

elmattic opened this issue Oct 15, 2024 · 0 comments
Labels
Type: Task Discrete task to implement

Comments

@elmattic
Copy link
Contributor

Summary

Our current message pool implementation in Forest lacks an observability feature. We have a Provider trait that abstracts how the message pool interacts with the "medium" (mainly used for testing). However, there is no way to notify the outside world about what is happening inside the message pool.

For instance, we want to track when a new message is added or removed, allowing other parts of the system (such as MempoolFilterManager) to react accordingly.

Requirements

  • Identify all other parts of Forest that require message pool observability.
  • Implement an observability mechanism in the message pool.
  • Ensure it works in the MempoolFilterManager.
  • Add comprehensive unit tests to the TestApi provider.

Motivation

This is a high-priority task, as it is likely to block progress on:

  • Filecoin.EthSubscribe
  • Filecoin.EthUnsubscribe
  • Filecoin.EthGetFilterChanges
  • Filecoin.EthGetFilterLogs
  • others?
@elmattic elmattic added Type: Request Requests to implement features or make other changes Type: Task Discrete task to implement and removed Type: Request Requests to implement features or make other changes labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task Discrete task to implement
Projects
Status: Ready
Development

No branches or pull requests

1 participant