Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't GC manifests #4959

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix: don't GC manifests #4959

wants to merge 18 commits into from

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Oct 31, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • blessed column for persistent storage

Reference issue to close (if applicable)

Closes #4926

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov marked this pull request as ready for review November 4, 2024 20:32
@ruseinov ruseinov requested a review from a team as a code owner November 4, 2024 20:32
@ruseinov ruseinov requested review from hanabi1224 and LesnyRumcajs and removed request for a team November 4, 2024 20:32
@ruseinov
Copy link
Contributor Author

ruseinov commented Nov 6, 2024

Follow-up issue - create common helpers to use for migrations and also for DB operations.
We have to duplicate the way that the keys are being constructed in several different manners, for e.g. EthMappings and the Graph. It would be nice to share the same code that is used by the application itself to avoid human error.

@ruseinov ruseinov mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224 hanabi1224 is a code owner automatically assigned from ChainSafe/forest

@LesnyRumcajs LesnyRumcajs Awaiting requested review from LesnyRumcajs LesnyRumcajs is a code owner automatically assigned from ChainSafe/forest

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Garbage collector should not collect manifests
2 participants
@ruseinov @hanabi1224