Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review cached control #346

Open
twoeths opened this issue Sep 28, 2022 · 1 comment
Open

Review cached control #346

twoeths opened this issue Sep 28, 2022 · 1 comment
Labels
meta-investigate prio-low

Comments

@twoeths
Copy link
Contributor

twoeths commented Sep 28, 2022

Description
It seems the control inside gossipsub has no use from a review.

Also metrics show that it's consistently 0

Screen Shot 2022-09-28 at 12 43 16
@wemeetagain
Copy link
Member

This needs more investigation. It seems that control is only used to retry sending control messages if they fail to be sent the first time. This may not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-investigate prio-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wemeetagain @twoeths @philknows