refactor: dont create separate variable, use object prop

matthewkeil · matthewkeil · commit 119261867d7a · 2025-09-09T02:07:42.000+07:00
diff --git a/packages/beacon-node/src/sync/range/utils/peerBalancer.ts b/packages/beacon-node/src/sync/range/utils/peerBalancer.ts
@@ -118,7 +118,7 @@ export class ChainPeersBalancer {
     }
 
     for (const peer of this.peers) {
-      const {earliestAvailableSlot, custodyGroups, target, peerId} = peer;
+      const {earliestAvailableSlot, target, peerId} = peer;
 
       const activeRequest = this.activeRequestsByPeer.get(peerId) ?? 0;
       if (noActiveRequest && activeRequest > 0) {
@@ -163,8 +163,7 @@ export class ChainPeersBalancer {
         continue;
       }
 
-      const peerColumns = custodyGroups;
-      const columns = peerColumns.reduce((acc, elem) => {
+      const columns = peer.custodyGroups.reduce((acc, elem) => {
         if (requestColumns.includes(elem)) {
           acc.push(elem);
         }

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ export class ChainPeersBalancer {`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`for (const peer of this.peers) {`
`121`		`- const {earliestAvailableSlot, custodyGroups, target, peerId} = peer;`
	`121`	`+ const {earliestAvailableSlot, target, peerId} = peer;`
`122`	`122`
`123`	`123`	`const activeRequest = this.activeRequestsByPeer.get(peerId) ?? 0;`
`124`	`124`	`if (noActiveRequest && activeRequest > 0) {`
`@@ -163,8 +163,7 @@ export class ChainPeersBalancer {`
`163`	`163`	`continue;`
`164`	`164`	`}`
`165`	`165`
`166`		`- const peerColumns = custodyGroups;`
`167`		`- const columns = peerColumns.reduce((acc, elem) => {`
	`166`	`+ const columns = peer.custodyGroups.reduce((acc, elem) => {`
`168`	`167`	`if (requestColumns.includes(elem)) {`
`169`	`168`	`acc.push(elem);`
`170`	`169`	`}`