Sort attestations for block by profitability #8019
Description
As proposed in #8016 it would be ideal to sort attestations for block by profitability but it does not have a large impact on block reward right now since we barely fill the block with 8 attestations in which case the sorting does not matter.
Keeping the current sorting / scoring is good for blockprint as it’s slightly different from other clients and should help differentiate Lodestar.
But we should revisit in the future / in different network conditions as it could make a difference during non-finality when there are a lot of different votes (less consolidation) + missed slots which require us to fill up the block most of the time.