Merge branch 'release/7.5.1'

Author: Jaben

.github/workflows/winget-publish.yml

@@ -117,9 +117,12 @@ jobs:
             Write-Host ""
             Write-Host "To enable automatic PR creation in the future:"
             Write-Host "  1. Fork https://github.com/microsoft/winget-pkgs"
-            Write-Host "  2. Create a GitHub Personal Access Token with 'repo' and 'workflow' scopes"
+            Write-Host "  2. Create a GitHub Personal Access Token (classic) with 'repo' and 'workflow' scopes"
+            Write-Host "     OR create a Fine-grained token with:"
+            Write-Host "       - Repository access: All repositories (or specific fork)"
+            Write-Host "       - Permissions: Contents (Read and write), Pull requests (Read and write)"
             Write-Host "  3. Add it as WINGET_PUBLISH_TOKEN secret in your repository settings"
-            Write-Host "  4. Optionally set WINGET_PKGS_FORK secret to 'YourUsername/winget-pkgs'"
+            Write-Host "  4. Set WINGET_PKGS_FORK secret to 'YourUsername/winget-pkgs' (not the org name)"
             Write-Host ""
             Write-Host "To submit this release manually:"
             Write-Host "  1. Download the 'winget-manifests-${{ steps.version.outputs.VERSION }}' artifact from this workflow run"
@@ -146,6 +149,14 @@ jobs:
           # Clone the fork
           Write-Host "Cloning fork repository..."
           git clone "https://x-access-token:${{ secrets.WINGET_PUBLISH_TOKEN }}@github.com/$forkRepo.git" winget-pkgs-fork
+          if ($LASTEXITCODE -ne 0) {
+            Write-Error "Failed to clone fork repository."
+            Write-Error "This usually means:"
+            Write-Error "  1. The WINGET_PUBLISH_TOKEN doesn't have access to $forkRepo"
+            Write-Error "  2. The WINGET_PKGS_FORK secret is set incorrectly (should be 'YourUsername/winget-pkgs')"
+            Write-Error "  3. The token doesn't have 'repo' scope or Contents (Read and write) permission"
+            exit 1
+          }
           cd winget-pkgs-fork
 
           # Add upstream and fetch
@@ -172,7 +183,15 @@ jobs:
           git commit -m "New version: $packageId version $version"
 
           Write-Host "Pushing to fork..."
-          git push origin $branchName
+          git push "https://x-access-token:${{ secrets.WINGET_PUBLISH_TOKEN }}@github.com/$forkRepo.git" $branchName
+          if ($LASTEXITCODE -ne 0) {
+            Write-Error "Failed to push to fork repository."
+            Write-Error "This usually means:"
+            Write-Error "  1. The WINGET_PUBLISH_TOKEN doesn't have write access to $forkRepo"
+            Write-Error "  2. The token doesn't have 'repo' scope or Contents (Read and write) permission"
+            Write-Error "  3. The branch already exists (try deleting it from the fork)"
+            exit 1
+          }
 
           # Create PR using GitHub CLI
           Write-Host "Creating pull request..."
@@ -183,6 +202,17 @@ jobs:
             --base master `
             --head "$forkRepo`:$branchName"
 
+          if ($LASTEXITCODE -ne 0) {
+            Write-Error "Failed to create pull request."
+            Write-Error "This usually means:"
+            Write-Error "  1. The WINGET_PUBLISH_TOKEN doesn't have 'workflow' scope or Pull requests (Read and write) permission"
+            Write-Error "  2. A PR with the same head branch already exists"
+            Write-Error "  3. The token is a fine-grained token without access to the microsoft/winget-pkgs repository"
+            Write-Error ""
+            Write-Error "Note: You may need to use a classic PAT with 'public_repo' and 'workflow' scopes."
+            exit 1
+          }
+
           Write-Host ""
           Write-Host "✓ Pull request created successfully!"
           Write-Host "The microsoft/winget-pkgs maintainers will review and merge the PR."

ReleaseNotes.md

@@ -1,5 +1,18 @@
 # Release Notes
 
+## Papercut SMTP v7.5.1 [2025-10-31]
+
+### Bug Fixes
+
+- **Forwarding Rules Failing** - Fixed critical bug where email forwarding rules were completely broken due to TaskCanceledException. Fixes [#331](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/331) (Thanks, [wcwhitehead](https://github.com/wcwhitehead)!)
+- **SSL/TLS Connection Mode** - Fixed SSL/TLS connection mode to use SslOnConnect for port 465 and Auto for STARTTLS
+- **SMTP Timeout** - Set proper SMTP timeout of 30 seconds for forwarding rules
+- **Backend Service Status** - Fixed initial status detection for backend service
+
+### Contributors
+
+Special thanks to [wcwhitehead](https://github.com/wcwhitehead) for reporting the critical forwarding rules bug!
+
 ## Papercut SMTP v7.5.0 [2025-10-28]
 
 ### New Features

ReleaseNotesCurrent.md

@@ -1,57 +1,14 @@
 # Release Notes
 
-## Papercut SMTP v7.5.0 [2025-10-28]
-
-### New Features
-
-- **Search Functionality** - Added Ctrl+F search to all message detail views (Message, Body, Headers, and Raw). Fixes [#295](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/295)
-- **Zoom Controls** - Added Ctrl+Mouse Scroll Wheel zoom support to message detail views with persistence and visual indicators. Fixes [#323](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/323)
-- **Attachment Display** - Attachments now display in the main message panel with icons and easy access. Fixes [#112](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/112)
-- **Context Menu for Links** - Right-click context menu added for email links with copy and open functionality. Fixes [#218](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/218)
-- **Empty State Placeholders** - Added smart empty state messaging to message list and detail views for better first-time user experience. Fixes [#268](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/268)
-- **SMTP Authentication and TLS/STARTTLS Support** - Full support for SMTP authentication and TLS/STARTTLS encryption for secure email testing. Fixes [#102](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/102)
-- **Periodic Background Rules** - Added periodic background rule execution with mail retention cleanup to both UI and Service. Related to [#251](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/251)
-- **Windows Package Manager (winget) Support** - Papercut SMTP can now be installed and updated via winget. Fixes [#231](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/231)
-- **File Links Support** - Made file:/// links functional by opening with shell/explorer. Fixes [#232](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/232)
-- **Example Console Applications** - Added comprehensive example console applications for email testing scenarios
-- **Installer Help Support** - Added help parameter support for PowerShell/cmd users. Fixes [#287](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/287)
-
-### Improvements
-
-- **Word-Wrap Support** - Added CSS word-wrap support to HTML email rendering for better display of long text strings. Fixes [#154](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/154)
-- **Non-Standard Email Domains** - Added support for non-standard email domains in development environments (e.g., .local, .dev). Fixes [#284](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/284)
-- **SSL Certificate Error Handling** - Added optional SSL certificate error handling for WebView2 to support self-signed certificates. Fixes [#243](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/243)
-- **Comprehensive Unit Tests** - Added extensive unit tests with FluentAssertions for improved code quality and reliability
-- **NuGet Package Upgrades** - Upgraded all NuGet packages to latest versions, including migration to new Polly ResiliencePipeline API
-- **Service Architecture** - Refactored attachment and process handling into dedicated services for better separation of concerns
-- **Settings Debouncing** - Implemented debounced settings saves using Rx Throttle operator to reduce unnecessary I/O
+## Papercut SMTP v7.5.1 [2025-10-31]
 
 ### Bug Fixes
 
-- **Window Size Saving** - Fixed window size not saving correctly when minimized. Fixes [#327](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/327)
-- **PDF Attachment Opening** - Fixed PDF attachment opening on Windows 11 24H2 and double-click issues. Fixes [#310](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/310), [#280](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/280)
-- **Message Rendering with # Characters** - Fixed message rendering for subjects containing # characters. Fixes [#282](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/282) (Thanks, [xavero](https://github.com/xavero)!)
-- **SMTP IP Logging** - Fixed SMTP service not logging remote client IP address correctly. Fixes [#291](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/291)
-- **Empty State Flicker** - Fixed placeholder flicker when switching between emails
-- **WebView2 Deserialization** - Added robust error handling for WebView2 message deserialization
-- **Null Safety** - Various null safety improvements and fixes throughout the codebase
-- **Process.Start Null Checks** - Added null checks for Process.Start return values to prevent exceptions
-
-### Code Quality
-
-- Refactored to use IUiCommandHub.ShowMessage instead of MessageBox.Show for better testability
-- Extracted debouncing logic into reusable SettingsSaveDebouncer
-- Improved async patterns and error handling in example applications
-- Fixed test assertions to use FluentAssertions consistently
-- Added nullable reference type attributes throughout codebase
-
-### Documentation
-
-- Added comprehensive TLS/STARTTLS setup documentation with Docker examples
-- Created example projects: SendEmailTest, SendRichEmailTest, SendWordWrapTest, SendEmailWithTls, SendEmailWithFileLinks
-- Improved Docker documentation with troubleshooting guides
-- Added installation guide for PowerShell and command-line users
+- **Forwarding Rules Failing** - Fixed critical bug where email forwarding rules were completely broken due to TaskCanceledException. Fixes [#331](https://github.com/ChangemakerStudios/Papercut-SMTP/issues/331) (Thanks, [wcwhitehead](https://github.com/wcwhitehead)!)
+- **SSL/TLS Connection Mode** - Fixed SSL/TLS connection mode to use SslOnConnect for port 465 and Auto for STARTTLS
+- **SMTP Timeout** - Set proper SMTP timeout of 30 seconds for forwarding rules
+- **Backend Service Status** - Fixed initial status detection for backend service
 
 ### Contributors
 
-Special thanks to [xavero](https://github.com/xavero) for fixing message rendering with # characters!
+Special thanks to [wcwhitehead](https://github.com/wcwhitehead) for reporting the critical forwarding rules bug!

installation/winget/ChangemakerStudios.PapercutSMTP.installer.yaml

@@ -1,5 +1,5 @@
 PackageIdentifier: "ChangemakerStudios.PapercutSMTP"
-PackageVersion: "7.5.0"
+PackageVersion: "7.5.1"
 Platform:
 - "Windows.Desktop"
 MinimumOSVersion: "10.0.17763.0"
@@ -13,13 +13,13 @@ InstallerSwitches:
 UpgradeBehavior: "install"
 Installers:
 - Architecture: "x64"
-  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.0/PapercutSMTP-win-x64-stable-Setup.exe"
+  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.1/PapercutSMTP-win-x64-stable-Setup.exe"
   InstallerSha256: "<SHA256_HASH_x64>"
 - Architecture: "x86"
-  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.0/PapercutSMTP-win-x86-stable-Setup.exe"
+  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.1/PapercutSMTP-win-x86-stable-Setup.exe"
   InstallerSha256: "<SHA256_HASH_x86>"
 - Architecture: "arm64"
-  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.0/PapercutSMTP-win-arm64-stable-Setup.exe"
+  InstallerUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/download/7.5.1/PapercutSMTP-win-arm64-stable-Setup.exe"
   InstallerSha256: "<SHA256_HASH_arm64>"
 ManifestType: "installer"
 ManifestVersion: "1.6.0"

installation/winget/ChangemakerStudios.PapercutSMTP.locale.en-US.yaml

@@ -1,5 +1,5 @@
 PackageIdentifier: "ChangemakerStudios.PapercutSMTP"
-PackageVersion: "7.5.0"
+PackageVersion: "7.5.1"
 PackageLocale: "en-US"
 Publisher: "Changemaker Studios"
 PublisherUrl: "https://github.com/ChangemakerStudios"
@@ -29,7 +29,7 @@ Tags:
 - "testing"
 - "developer-tools"
 - "mail-server"
-ReleaseNotes: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/tag/7.5.0"
-ReleaseNotesUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/tag/7.5.0"
+ReleaseNotes: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/tag/7.5.1"
+ReleaseNotesUrl: "https://github.com/ChangemakerStudios/Papercut-SMTP/releases/tag/7.5.1"
 ManifestType: "defaultLocale"
 ManifestVersion: "1.6.0"

installation/winget/ChangemakerStudios.PapercutSMTP.yaml

@@ -1,5 +1,5 @@
 PackageIdentifier: "ChangemakerStudios.PapercutSMTP"
-PackageVersion: "7.5.0"
+PackageVersion: "7.5.1"
 DefaultLocale: "en-US"
 ManifestType: "version"
 ManifestVersion: "1.6.0"

installation/winget/README.md

@@ -59,7 +59,7 @@ You can also manually trigger the winget publishing workflow:
 
 ```bash
 # Via GitHub CLI
-gh workflow run winget-publish.yml --ref master -f version=7.5.0
+gh workflow run winget-publish.yml --ref master -f version=7.5.1
 
 # Or use the GitHub Actions UI and select "Run workflow"
 ```
@@ -116,7 +116,7 @@ If automated publishing is not configured, you can manually submit to winget:
 #### Option B: Use wingetcreate Tool
 
 ```powershell
-$version = "7.5.0"
+$version = "7.5.1"
 wingetcreate update ChangemakerStudios.PapercutSMTP `
   --version $version `
   --urls `

src/Papercut.Rules/App/Relaying/RelayRuleExtensions.cs

@@ -38,12 +38,16 @@ public static async Task<SmtpClient> CreateConnectedSmtpClientAsync(this RelayRu
     {
         if (forwardRule == null) throw new ArgumentNullException(nameof(forwardRule));
 
-        var client = new SmtpClient();
+        var client = new SmtpClient
+        {
+            // Set reasonable timeout (default is 100 seconds, set to 30 seconds)
+            Timeout = 30000
+        };
 
         await client.ConnectAsync(
             forwardRule.SmtpServer,
             forwardRule.SmtpPort,
-            forwardRule.SmtpUseSSL ? SecureSocketOptions.Auto : SecureSocketOptions.None,
+            forwardRule.SmtpUseSSL ? SecureSocketOptions.SslOnConnect : SecureSocketOptions.Auto,
             token);
 
         // Note: since we don't have an OAuth2 token, disable

src/Papercut.Rules/App/RulesRunner.cs

@@ -65,8 +65,6 @@ public async Task RunNewMessageRules(INewMessageRule[] rules, MessageEntry messa
 
         foreach (var rule in rules.Where(r => r.IsEnabled))
         {
-            token.ThrowIfCancellationRequested();
-
             var invoke = _dispatchRuleMethod.MakeGenericMethod(rule.GetType()).Invoke(
                 this,
                 [rule, messageEntry, token]);
@@ -88,8 +86,6 @@ public Task RunPeriodicBackgroundRules(IPeriodicBackgroundRule[] rules, Cancella
 
         foreach (var rule in rules.Where(r => r.IsEnabled))
         {
-            token.ThrowIfCancellationRequested();
-
             var invoke = _dispatchRuleMethod.MakeGenericMethod(rule.GetType()).Invoke(
                 this,
                 [rule, null, token]);

src/Papercut.UI/AppLayer/IpComm/BackendServiceCoordinator.cs

@@ -79,6 +79,8 @@ public async Task OnStartedAsync()
         await this.AttemptExchangeAsync();
     }
 
+    private bool IsOnlineUnknown => _isOnline is null;
+
     public bool IsOnline
     {
         get => this._isOnline ?? false;
@@ -119,7 +121,7 @@ public async Task HandleAsync(SettingsUpdatedEvent @event, CancellationToken tok
 
     private async Task SetOnlineStatus(bool newStatus, CancellationToken token = default)
     {
-        if (this._isOnline != newStatus)
+        if (IsOnlineUnknown || this.IsOnline != newStatus)
         {
             this.IsOnline = newStatus;