Skip to content

Add aux_tags suboption for tags in tag_group module #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: devel
Choose a base branch
from

Conversation

meni2029
Copy link
Contributor

@meni2029 meni2029 commented Apr 3, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The aux_tags suboption for the tags in the tag_group module is not available, while it was possible to declare it in previous collection version (i.e. 3.4.0).

What is the new behavior?

  • Added the aux_tags suboption for the tags in the tag_group module
  • The suboption is optional and default value is an empty list ([])
  • The aux_tags is now used in the changes_detected function

Other information

It has been tested on Checkmk 2.3.0p27. It might not fully work with 2.2 as, if I remember correctly, the API returns no "aux_tags" item if there's none selected. At least in 2.3, the API always returns it with empty list if none selected, so default => []:

"topic": "Notifications",
    "tags": [
        {
            "id": "yes",
            "title": "of course",
            "aux_tags": []
        }

@github-actions github-actions bot added the module:tag_group This affects the tag_group module label Apr 3, 2025
@robin-checkmk robin-checkmk self-assigned this Apr 3, 2025
@robin-checkmk
Copy link
Member

Hi @meni2029 and thank you for your contribution! Looks good to me so far.
Do you think you can add one or two integration tests, which verify that the feature works as intended?
That would be highly appreciated! If not, I can take care of it as well.

@meni2029
Copy link
Contributor Author

Hi @robin-checkmk
Thanks for your reply. I will have a look at the integration tests.

@meni2029
Copy link
Contributor Author

Hi @robin-checkmk ,
I added integration tests. For the tests I create the aux_tags with direct API call, as there's no module for aux_tags.
Hopefully this is ok.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:tag_group This affects the tag_group module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants