Skip to content

refactor: update pdfjs import and improve file filtering in electron-builder configuration #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

beyondkmp
Copy link
Collaborator

…builder configuration

  • Changed pdfjs import to a direct import from 'pdfjs-dist' for consistency across modules.
  • Updated file filtering in electron-builder.yml to exclude all legacy files from pdfjs-dist instead of just specific ones.

What this PR does

Before this PR:

pdfjs没有复用

After this PR:
pdfjs复用,并用删除legacy/build

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note


…builder configuration

- Changed pdfjs import to a direct import from 'pdfjs-dist' for consistency across modules.
- Updated file filtering in electron-builder.yml to exclude all legacy files from pdfjs-dist instead of just specific ones.
@beyondkmp beyondkmp added this to the v1.5.1 milestone Jul 16, 2025
@alephpiece alephpiece requested a review from eeee0717 July 19, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants