Skip to content

Commit 8ab9fe4

Browse files
subaha-cobsubaha-cob
authored
Merge pull request #810 from CityOfBoston/develop
DIG-5685 Reduce padding at the bottom of 'Formatted Text' components
2 parents 6a1dae4 + 6be74a7 commit 8ab9fe4

File tree

5 files changed

+349
-0
lines changed

5 files changed

+349
-0
lines changed

‎.github/percy/percy_config.yml

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# @file(yaml)
2+
# Global Configurations for Percy CLI
3+
version: 2
4+
snapshot:
5+
widths: [390,1280]
6+
minHeight: 1024
7+
percyCSS: ""
8+
discovery:
9+
allowedHostnames: []
10+
disallowedHostnames: []
11+
networkIdleTimeout: 100
12+
upload:
13+
files: "**/*.{png,jpg,jpeg}"
14+
ignore: ""
15+
stripExtensions: false

‎.github/percy/snapshot_config.yml

+106
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,106 @@
1+
2+
3+
- name: Article with ALL components
4+
url: https://d8-dev.boston.gov/departments/digital-team/test-page
5+
waitForTimeout: 5000
6+
execute: |
7+
jQuery('.paragraphs-item-events-and-notices').addClass("hidden");
8+
9+
- name: Event (basic) - WEST END COMMUNITY PRESERVATION
10+
url: https://d8-dev.boston.gov/node/61556
11+
12+
- name: Event (with header) - MAYOR ON MAIN TROLLEY TOUR
13+
url: https://d8-dev.boston.gov/node/45361
14+
15+
- name: Listing Page - PAY AND APPLY
16+
url: https://d8-dev.boston.gov/node/32906
17+
18+
- name: Listing Page - PARKS AND PLAYGROUNDS
19+
url: https://d8-dev.boston.gov/node/32946
20+
21+
- name: Place Profile - ANIMAL CARE AND CONTROL CENTER
22+
url: https://d8-dev.boston.gov/node/2191
23+
24+
- name: Place Profile - BAY VILLAGE HISTORIC DISTRICT
25+
url: https://d8-dev.boston.gov/node/3251
26+
27+
- name: Person Profile - MARK CIOMMO
28+
url: https://d8-dev.boston.gov/node/401
29+
30+
- name: Person Profile - KIM JANEY
31+
url: https://d8-dev.boston.gov/node/38046
32+
33+
- name: Program Initiative Page - MY BROTHERS KEEPER BOSTON
34+
url: https://d8-dev.boston.gov/node/7396
35+
36+
- name: Program Initiative Page - AGE-FRIENDLY BOSTON
37+
url: https://d8-dev.boston.gov/node/25396
38+
39+
- name: Post - BIKE SHARE
40+
url: https://d8-dev.boston.gov/node/1741
41+
42+
- name: Post - RODENT AND PEST CONTROL
43+
url: http://d8-dev.boston.gov/node/63036
44+
45+
- name: How To - CPR TRAINING
46+
url: https://d8-dev.boston.gov/node/3606
47+
execute: |
48+
jQuery('.dr-tr:last()').click();
49+
# Expands last drawer on page
50+
51+
- name: How To - FILE FOR A PROPERTY TAX ABATEMENT
52+
url: https://d8-dev.boston.gov/node/12806
53+
execute: |
54+
jQuery('.dr-tr:last()').click();
55+
# Expands last drawer on page
56+
57+
- name: Article - PARKING METERS
58+
url: https://d8-dev.boston.gov/node/551
59+
60+
- name: Article - MAYORS OFFICE OF HOUSING
61+
url: https://d8-dev.boston.gov/node/2726
62+
63+
- name: Department - INSPECTIONAL SERVICES
64+
url: https://d8-dev.boston.gov/node/151
65+
execute: |
66+
jQuery('.paragraphs-item-events-and-notices').addClass("hidden");
67+
# Hides dynamic content on page to reduce false positives for changes
68+
69+
- name: Department - HUMAN RESOURCES
70+
url: https://d8-dev.boston.gov/node/216
71+
execute: |
72+
jQuery('.dr-c:first()').;
73+
# Expands first drawer on page
74+
75+
- name: Public Notice - PUBLIC FACILITIES COMMISSION MEETING
76+
url: https://d8-dev.boston.gov/node/64966
77+
78+
- name: Guide - GETTING AROUND BOSTON
79+
url: https://d8-dev.boston.gov/node/506
80+
81+
- name: Guide - HAVING A CAR IN BOSTON
82+
url: https://d8-dev.boston.gov/node/6
83+
84+
- name: Landing Page - HOMEPAGE
85+
url: https://d8-dev.boston.gov/node/21
86+
execute: |
87+
jQuery('.dr-tr:last()').click();
88+
# Expands first drawer on page
89+
90+
- name: Landing Page - CAREER CENTER
91+
url: https://d8-dev.boston.gov/node/19261
92+
execute: |
93+
jQuery('.paragraphs-item-grid-of-cards:first()').addClass("hidden");
94+
# Hides dynamic content on page to reduce false positives for changes
95+
96+
- name: Procurement - INSPECTIONAL SERVICES RELATIVE TO ...
97+
url: https://d8-dev.boston.gov/node/15920681
98+
99+
- name: Procurement - BFD THERMAL IMAGING CAMERAS ...
100+
url: https://d8-dev.boston.gov/node/15920521
101+
102+
- name: Map Verification - 30 Westville St (BH)
103+
url: https://d8-dev.boston.gov/buildinghousing/30-westville-st
104+
105+
- name: Drawers Example - DRAWERS (INSPECTION SERVICES)
106+
url: https://d8-dev.boston.gov/node/3921

‎.github/percy/snapshot_config_stage.yml

+101
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,101 @@
1+
- name: Article with ALL components
2+
url: https://d8-stg.boston.gov/departments/digital-team/test-page
3+
waitForTimeout: 5000
4+
execute: |
5+
jQuery('.paragraphs-item-events-and-notices').addClass("hidden");
6+
7+
- name: Event (basic) - WEST END COMMUNITY PRESERVATION
8+
url: https://d8-stg.boston.gov/node/61556
9+
10+
- name: Event (with header) - MAYOR ON MAIN TROLLEY TOUR
11+
url: https://d8-stg.boston.gov/node/45361
12+
13+
- name: Listing Page - PAY AND APPLY
14+
url: https://d8-stg.boston.gov/node/32906
15+
16+
- name: Listing Page - PARKS AND PLAYGROUNDS
17+
url: https://d8-stg.boston.gov/node/32946
18+
19+
- name: Place Profile - ANIMAL CARE AND CONTROL CENTER
20+
url: https://d8-stg.boston.gov/node/2191
21+
22+
- name: Place Profile - BAY VILLAGE HISTORIC DISTRICT
23+
url: https://d8-stg.boston.gov/node/3251
24+
25+
- name: Person Profile - MARK CIOMMO
26+
url: https://d8-stg.boston.gov/node/401
27+
28+
- name: Person Profile - KIM JANEY
29+
url: https://d8-stg.boston.gov/node/38046
30+
31+
- name: Program Initiative Page - MY BROTHERS KEEPER BOSTON
32+
url: https://d8-stg.boston.gov/node/7396
33+
34+
- name: Program Initiative Page - AGE-FRIENDLY BOSTON
35+
url: https://d8-stg.boston.gov/node/25396
36+
37+
- name: Post - BIKE SHARE
38+
url: https://d8-stg.boston.gov/node/1741
39+
40+
- name: Post - RODENT AND PEST CONTROL
41+
url: http://d8-stg.boston.gov/node/63036
42+
43+
- name: How To - CPR TRAINING
44+
url: https://d8-stg.boston.gov/node/3606
45+
execute: |
46+
jQuery('.dr-tr:last()').click();
47+
# Expands last drawer on page
48+
49+
- name: How To - FILE FOR A PROPERTY TAX ABATEMENT
50+
url: https://d8-stg.boston.gov/node/12806
51+
execute: |
52+
jQuery('.dr-tr:last()').click();
53+
# Expands last drawer on page
54+
55+
- name: Article - PARKING METERS
56+
url: https://d8-stg.boston.gov/node/551
57+
58+
- name: Article - MAYORS OFFICE OF HOUSING
59+
url: https://d8-stg.boston.gov/node/2726
60+
61+
- name: Department - INSPECTIONAL SERVICES
62+
url: https://d8-stg.boston.gov/node/151
63+
execute: |
64+
jQuery('.paragraphs-item-events-and-notices').addClass("hidden");
65+
# Hides dynamic content on page to reduce false positives for changes
66+
67+
- name: Department - HUMAN RESOURCES
68+
url: https://d8-stg.boston.gov/node/216
69+
execute: |
70+
jQuery('.dr-c:first()').;
71+
# Expands first drawer on page
72+
73+
- name: Public Notice - PUBLIC FACILITIES COMMISSION MEETING
74+
url: https://d8-stg.boston.gov/node/64966
75+
76+
- name: Guide - GETTING AROUND BOSTON
77+
url: https://d8-stg.boston.gov/node/506
78+
79+
- name: Guide - HAVING A CAR IN BOSTON
80+
url: https://d8-stg.boston.gov/node/6
81+
82+
- name: Landing Page - HOMEPAGE
83+
url: https://d8-stg.boston.gov/node/21
84+
execute: |
85+
jQuery('.dr-tr:last()').click();
86+
# Expands first drawer on page
87+
88+
- name: Landing Page - CAREER CENTER
89+
url: https://d8-stg.boston.gov/node/19261
90+
execute: |
91+
jQuery('.paragraphs-item-grid-of-cards:first()').addClass("hidden");
92+
# Hides dynamic content on page to reduce false positives for changes
93+
94+
- name: Procurement - INSPECTIONAL SERVICES RELATIVE TO ...
95+
url: https://d8-stg.boston.gov/node/15920681
96+
97+
- name: Procurement - BFD THERMAL IMAGING CAMERAS ...
98+
url: https://d8-stg.boston.gov/node/15920521
99+
100+
- name: Map Verification - 30 Westville St (BH)
101+
url: https://d8-stg.boston.gov/buildinghousing/30-westville-st

‎.github/workflows/percy_snapshot.yml

+120
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
# @file(yaml)
2+
# == GITHUB ACTION ==
3+
# Percy screenshot scripting for patterns.boston.gov
4+
# Workflow monitors master branch and is triggered by a Pull Request.
5+
# The action is triggered before the code reaches the environment, so the workflow compares screenshots taken
6+
# from the lower environment.
7+
8+
# Attached resources:
9+
# - GitHub SECRETS:
10+
# -> local.PERCY_TOKEN_STAGE -> Notify people that release is ready.
11+
# -> local.PERCY_TOKEN -> Notify people that release is ready.
12+
13+
name: Percy Snapshot Regression Testing
14+
15+
env:
16+
PERCY_CONFIG: "$GITHUB_WORKSPACE/.github/percy/percy_config.yml"
17+
18+
on:
19+
workflow_dispatch:
20+
pull_request:
21+
branches:
22+
- production
23+
types:
24+
- opened
25+
- reopened
26+
- synchronize
27+
28+
jobs:
29+
30+
debug:
31+
runs-on: ubuntu-latest
32+
if: ${{ vars.DEBUG == 1 }}
33+
34+
defaults:
35+
run:
36+
shell: bash
37+
38+
steps:
39+
- name: Debug ENVARS
40+
run: |
41+
export
42+
43+
- name: Debug github context
44+
env:
45+
GITHUB_CONTEXT: ${{ toJSON(github) }}
46+
run: |
47+
echo $GITHUB_CONTEXT
48+
49+
- name: Debug github.event context
50+
env:
51+
EVENT_CONTEXT: ${{ toJSON(github.event) }}
52+
run: |
53+
echo $EVENT_CONTEXT
54+
55+
56+
percy_manual:
57+
58+
if: github.event_name == 'workflow_dispatch'
59+
runs-on: ubuntu-latest
60+
61+
env:
62+
SNAPSHOT_CONFIG: "$GITHUB_WORKSPACE/.github/percy/snapshot_config.yml"
63+
64+
defaults:
65+
run:
66+
shell: bash
67+
68+
steps:
69+
- name: checkout percy files
70+
uses: Bhacaz/checkout-files@v2
71+
with:
72+
files: .github/percy
73+
branch: develop
74+
75+
- name: Setup Node 16
76+
uses: actions/setup-node@v3
77+
with:
78+
node-version: '16'
79+
80+
- name: Install Percy CLI
81+
run: npm install --save-dev @percy/cli
82+
83+
- name: Compare Frontend Snapshots
84+
run: |
85+
npx @percy/cli snapshot --config ${{ env.PERCY_CONFIG }} ${{ env.SNAPSHOT_CONFIG }}
86+
env:
87+
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
88+
89+
percy_production:
90+
91+
if: ${{ github.base_ref == 'production' }}
92+
runs-on: ubuntu-latest
93+
94+
env:
95+
SNAPSHOT_CONFIG: "$GITHUB_WORKSPACE/.github/percy/snapshot_config_stage.yml"
96+
97+
defaults:
98+
run:
99+
shell: bash
100+
101+
steps:
102+
- name: checkout percy files
103+
uses: Bhacaz/checkout-files@v2
104+
with:
105+
files: .github/percy
106+
branch: develop
107+
108+
- name: Setup Node 16
109+
uses: actions/setup-node@v3
110+
with:
111+
node-version: '16'
112+
113+
- name: Install Percy CLI
114+
run: npm install --save-dev @percy/cli
115+
116+
- name: Compare Frontend Snapshots
117+
run: |
118+
npx @percy/cli snapshot --config ${{ env.PERCY_CONFIG }} ${{ env.SNAPSHOT_CONFIG }}
119+
env:
120+
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN_STAGE }}

‎stylesheets/patterns-cob-theme.styl

+7
Original file line numberDiff line numberDiff line change
@@ -507,6 +507,13 @@ label {
507507
margin-bottom: 25px;
508508
padding-bottom: 3rem
509509
}
510+
.paragraphs-item-text .entity-paragraphs-item {
511+
margin-bottom: 0;
512+
padding-bottom: 0
513+
}
514+
.paragraphs-item-text .entity-paragraphs-item .supporting-lg, .paragraphs-item-text .entity-paragraphs-item.paragraphs-item-text-three-column {
515+
padding-bottom: 30px
516+
}
510517
.dr .squiggle-border-bottom .supporting-text {
511518
padding-bottom: 3rem
512519
}

0 commit comments

Comments
 (0)