Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: fix color contrast for alpha text in heading and about menu item #589

Open
dmundra opened this issue Jan 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@dmundra
Copy link
Contributor

dmundra commented Jan 7, 2022

Describe the bug

Running an updated version pa11y-ci and axe on the home page and other pages we are now getting errors regarding the color contrast of specifically the alpha text and about menu item. Here is the report

dmundra in ~/workspace/accessibility/accessibility on branch pa11y-ci-update > npm run pa11y-ci:home   

> pa11y-ci:home
> pa11y-ci http://127.0.0.1:4000

Running Pa11y on 1 URLs:
 > http://127.0.0.1:4000/ - 2 errors

Errors in http://127.0.0.1:4000/:

 • Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

   (#extended-logo > em > a > sup)

   <sup>ALPHA</sup>

 • Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

   (html > body > header > nav > div > ul > li:nth-child(1) > button > span)

   <span>About</span>

For now I am going to disable color-contrast checks in the .pa11yci file in #580 till we can fix this.

To Reproduce
Steps to reproduce the behavior:

  1. Check out code.
  2. Remove "color-contrast" from the ignore section in the .pa11yci file.
  3. Run npm run pa11y-ci:home
  4. See error

Expected behavior
Adjust the styling to pass Axe checks

@dmundra dmundra added the bug Something isn't working label Jan 7, 2022
@dmundra
Copy link
Contributor Author

dmundra commented Jan 7, 2022

The error is caused by axe not being able to calculate the color ratio. The browser extension returns this error message: Unable to determine contrast ratio. So there might not be a solution to this other than ignoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant