-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACF module does not analyse content inside Repeater and Flexible Content fields #27
Comments
OK, after further testing I'm going to redefine this issue. If you're editing a page and add a focus keyword that is already in the content (including within an ACF repeater or flexible content field), it is found. But if you add a focus keyword that is not currently in the content and then subsequently add it to the content, inside a repeater or flexible content field, it is not found. So the workaround is to delete the focus keyword, save the page, then re-add the focus keyword. |
Sounds like a bug. Will look into it. |
@zigpress are you still experiencing this problem? This is what I found in one particular test: Test
Result Does that match your own experience? I know this differs from the scenario you describe in your second post but I can't reproduce that. |
I'll test and respond asap, hopefully within 24 hours.
|
I just installed Classic SEO 0.7.0 on a localhost site, and followed the following steps:
I did the same exercise but with a plain (not ACF) page, pasting the lorem ipsum into the standard TinyMCE editor, and the problem in point 3 above did not occur. |
OK, thanks for testing this @zigpress . I will look into it further. |
Hi @zigpress I've had a good long play with Classic SEO and ACF and, you're not going to like this, but I can't reproduce the issue you report above. The first question I have is: are you still using v0.7.0? If so, can you update to the latest version (currently 1.0.0 beta 3) and see if you still have the problem. If you are running beta 3 and are still having the problem, read on... My setup is: PHP 7.2 I've recorded a screencast of my latest attempt which you can view here: https://drive.google.com/file/d/1FrllIklDC7BIrOeIzfQucJhyDLtBXFFF/view In the video, you may note that after saving the page, the SEO score briefly reverts to 4/100 before updating itself. This seems to be similar to what you are experiencing except that in your case, it does not update after saving. The second question is: are you getting any JavaScript errors when saving the page? If yes and you are running CPSEO v1.0.0 beta 3, can you let me know what the JS error(s) is(are) and can you also let me know your set up. Thanks |
I'm using 1.0.0-beta3. There are no errors in my JavaScript console, either when I load the page or when I add/remove focus keywords. EDIT: is there any way you can provide a version of the plugin where the JS files are not compressed onto one line? |
Weird. I've installed Brave Browser on my Windows PC and it works fine on that too, so definitely more testing required. I don't have the uncompressed versions of the JS files unfortunately. RM haven't made these available which, to my mind, goes against GPL. I have asked them but they were not very helpful. But that is on my list of things to do after I've released v1. |
I've noticed that on sites using ACF Pro, Classic SEO only reads top level WYSIWYG and Text fields when analysing the page content. Any content in Text or WYSIWYG fields that are inside Repeaters or Flexible Content fields are not read - as least as far as I can tell.
Obviously this doesn't affect Google, but because it affects the analysis and score on the editor page, it makes it harder to see whether my content is sufficiently optimised.
It would be great to have a more intelligent ACF module that can recursively dive into Repeater and Flexible Content fields to find any WYSIWYG or Text fields that may be inside them.
The text was updated successfully, but these errors were encountered: