fixes

Author: nefrathenrici

docs/src/api.md

@@ -43,12 +43,21 @@ ClimaAtmos.InitialConditions.Bomex
 ClimaAtmos.InitialConditions.Soares
 ```
 
-### Helper
+## Helper
 
 ```@docs
 ClimaAtmos.InitialConditions.ColumnInterpolatableField
 ```
 
+## Grids
+
+```@docs
+ClimaAtmos.ColGrid
+ ClimaAtmos.SphereGrid
+ClimaAtmos.PlaneGrid
+ClimaAtmos.BoxGrid
+```
+
 ## Jacobian
 
 ```@docs

src/simulation/grids.jl

@@ -6,7 +6,7 @@ domain system but use ClimaCore grids directly.
 """
 
 using ClimaCore: Geometry, Hypsography, Fields, Spaces, Meshes
-using ClimaCore.CommonGrids: ExtrudedCubedSphereGrid, ColumnGrid, Box3DGrid, SliceXZGrid
+using ClimaCore.CommonGrids: ExtrudedCubedSphereGrid, ColumnGrid, Box3DGrid, SliceXZGrid, DefaultZMesh
 using ClimaUtilities: SpaceVaryingInputs.SpaceVaryingInput
 import .AtmosArtifacts as AA
 import ClimaComms
@@ -123,10 +123,16 @@ function ColGrid(
 )
     stretch =
         z_stretch ? Meshes.HyperbolicTangentStretching{FT}(dz_bottom) : Meshes.Uniform()
-
+    z_mesh = DefaultZMesh(
+        FT;
+        z_min = 0,
+        z_max,
+        z_elem,
+        stretch,
+    )
     grid = ColumnGrid(
         FT;
-        z_elem, z_min = 0, z_max,
+        z_elem, z_min = 0, z_max, z_mesh,
         device = ClimaComms.device(comms_ctx),
         context = comms_ctx,
         stretch,
@@ -199,10 +205,16 @@ function BoxGrid(
         topography, topography_damping_factor, mesh_warp_type,
         sleve_eta, sleve_s, topo_smoothing, comms_ctx,
     )
-
+    z_mesh = DefaultZMesh(
+        FT;
+        z_min = 0,
+        z_max,
+        z_elem,
+        stretch,
+    )
     grid = Box3DGrid(
         FT;
-        z_elem, x_min = 0, x_max, y_min = 0, y_max, z_min = 0, z_max,
+        z_elem, x_min = 0, x_max, y_min = 0, y_max, z_min = 0, z_max, z_mesh,
         periodic_x, periodic_y, n_quad_points, x_elem, y_elem,
         device = ClimaComms.device(comms_ctx),
         context = comms_ctx,
@@ -274,9 +286,17 @@ function PlaneGrid(
         sleve_eta, sleve_s, topo_smoothing, comms_ctx,
     )
 
+    z_mesh = DefaultZMesh(
+        FT;
+        z_min = 0,
+        z_max,
+        z_elem,
+        stretch,
+    )
+
     grid = SliceXZGrid(
         FT;
-        z_elem, x_elem, x_min = 0, x_max, z_min = 0, z_max,
+        z_elem, x_elem, x_min = 0, x_max, z_min = 0, z_max, z_mesh,
         periodic_x,
         n_quad_points,
         device = ClimaComms.device(comms_ctx),

src/solver/type_getters.jl

@@ -255,15 +255,21 @@ function get_spaces(grid, params, comms_ctx)
             ExtrudedFiniteDifferenceGrid or FiniteDifferenceGrid""",
         )
     end
-    h_elem = Spaces.n_elements_per_panel_direction(center_space)
     z_elem = Spaces.nlevels(center_space)
     ncols = Fields.ncolumns(center_space)
     ndofs_total = ncols * z_elem
-    hspace = Spaces.horizontal_space(center_space)
-    quad_style = Spaces.quadrature_style(hspace)
-    Nq = Quadratures.degrees_of_freedom(quad_style)
-
-    @info "Resolution stats: " Nq h_elem z_elem ncols ndofs_total
+    if grid isa Grids.ExtrudedFiniteDifferenceGrid
+        h_elem = Spaces.n_elements_per_panel_direction(center_space)
+        z_elem = Spaces.nlevels(center_space)
+        ncols = Fields.ncolumns(center_space)
+        ndofs_total = ncols * z_elem
+        hspace = Spaces.horizontal_space(center_space)
+        quad_style = Spaces.quadrature_style(hspace)
+        Nq = Quadratures.degrees_of_freedom(quad_style)
+        @info "Resolution stats: " Nq h_elem z_elem ncols ndofs_total
+    else
+        @info "Resolution stats: " z_elem ncols ndofs_total
+    end
     return (; center_space, face_space)
 end
 
@@ -750,7 +756,7 @@ function get_grid(parsed_args, params, comms_ctx)
             topo_smoothing = parsed_args["topo_smoothing"],
         )
     elseif parsed_args["config"] == "column"
-        ColumnGrid(
+        ColGrid(
             FT,
             params,
             comms_ctx;

src/utils/utilities.jl

@@ -271,6 +271,9 @@ function do_dss(space::Spaces.AbstractSpace)
            Quadratures.GLL
 end
 
+function do_dss(space::Spaces.FiniteDifferenceSpace)
+    return false
+end
 
 using ClimaComms
 is_distributed(::ClimaComms.SingletonCommsContext) = false