Skip to content

Flux.loadmodel! does not work with old neural_snow model states #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imreddyTeja opened this issue Mar 6, 2025 · 0 comments · Fixed by #1054
Closed

Flux.loadmodel! does not work with old neural_snow model states #1061

imreddyTeja opened this issue Mar 6, 2025 · 0 comments · Fixed by #1054
Assignees
Labels

Comments

@imreddyTeja
Copy link
Member

imreddyTeja commented Mar 6, 2025

Describe the bug

The get_znetwork() and tests/standalone/Snow/tool_tests.jl error when Flux.loadmodel! is called.

It also seems like this test is not exercised with CI.

The test also looks like it was not updated after recent PRs that changed the snow model.

There is also a deprecation of implicitly taking the gradient with Flux.jl. This requires some changed to the way the model is setup.

Lastly, NeuralSnowExt is conditionally loaded with cuDNN. cuDNN is no longer maintained, and its functionality is replaced by cuArrays, which is deprecated and replaced by CUDA.

To Reproduce

Run tests/standalone/Snow/tool_tests.jl with CUDA

julia> include("test/standalone/Snow/tool_tests.jl")
Test Summary:          | Pass  Total  Time
Testing Data Utilities |   43     43  1.6s
Testing Model Utilities: Error During Test at /home/treddy/ClimaLand.jl/test/standalone/Snow/tool_tests.jl:213
  Got exception outside of a @test
  ArgumentError: Tried to load (:layers,) into (:layers, :connection) but the structures do not match.

Or even better, add it as a unit test, and open pull request.

Project

If not using the `examples` project: ``` paste your Project.toml here. ``` ``` paste your Manifest.toml here. ```

System details

Ran on Clima cluster.

Related issues / PRs

relates to #974

Similar issues in other repos: issue

Please add any relevant links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant