Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency on ClimaCore for test suite #185

Open
sriharshakandala opened this issue Jun 13, 2023 · 8 comments
Open

Circular dependency on ClimaCore for test suite #185

sriharshakandala opened this issue Jun 13, 2023 · 8 comments

Comments

@sriharshakandala
Copy link
Member

sriharshakandala commented Jun 13, 2023

ClimaTimeSteppers.jl test suite has tests that depend on ClimaCore, creating a circular dependency.

Solution

Move these tests to ClimaCore and eliminate the circular dependency

@sriharshakandala
Copy link
Member Author

cc: @simonbyrne

@charleskawczynski
Copy link
Member

There's no circular dependency-- ClimaCore does not depend on ClimaTimeSteppers.jl, and ClimaTimeSteppers.jl does not depend on ClimaCore. The ClimaTimeSteppers test environment depends on both, but that's fine. What's the issue here? Are you getting an error?

@simonbyrne
Copy link
Member

it does make it hard to upgrade ClimaComms, as we can't run the ClimaTimeSteppers tests until we've upgraded ClimaCore, and vice versa.

@charleskawczynski
Copy link
Member

Would it help if we made ClimaTimeSteppers not depend on ClimaComms? We can (and probably should anyway) undo this patch: 45fa591. Then we can remove the ClimaComms dependency. I'll do that now

@simonbyrne
Copy link
Member

We need it for some of the callbacks

@charleskawczynski
Copy link
Member

Ah, right

@charleskawczynski
Copy link
Member

Would it help if we added a buildkite job in ClimaTimeSteppers that depends on the ClimaCore main branch?

@charleskawczynski
Copy link
Member

I suppose we could make ClimaTimeSteppers a lib in ClimaCore. This would make updates easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants