-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular dependency on ClimaCore for test suite #185
Comments
cc: @simonbyrne |
There's no circular dependency-- ClimaCore does not depend on ClimaTimeSteppers.jl, and ClimaTimeSteppers.jl does not depend on ClimaCore. The ClimaTimeSteppers test environment depends on both, but that's fine. What's the issue here? Are you getting an error? |
it does make it hard to upgrade ClimaComms, as we can't run the ClimaTimeSteppers tests until we've upgraded ClimaCore, and vice versa. |
Would it help if we made ClimaTimeSteppers not depend on ClimaComms? We can (and probably should anyway) undo this patch: 45fa591. Then we can remove the ClimaComms dependency. I'll do that now |
We need it for some of the callbacks |
Ah, right |
Would it help if we added a buildkite job in ClimaTimeSteppers that depends on the ClimaCore main branch? |
I suppose we could make ClimaTimeSteppers a lib in ClimaCore. This would make updates easier |
ClimaTimeSteppers.jl
test suite has tests that depend onClimaCore
, creating a circular dependency.Solution
Move these tests to
ClimaCore
and eliminate the circular dependencyThe text was updated successfully, but these errors were encountered: