Make RK3 time-stepping compatible with CATKE #4019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ss/rk3-for-catke
|
You could also update how CATKE works so that things are correct when you aren't using substepping. And then just only support substepping as time allows |
|
Sounds good. I have implemented this strategy for the moment (just revert to the standard tracer time stepping if |
glwagner
reviewed
Dec 22, 2024
| const FlavorOfCATKE{TD} = Union{CATKEVD{TD}, CATKEVDArray{TD}} where TD | ||
| const CATKEVD{TD} = CATKEVerticalDiffusivity{TD, <:Any, <:Any, DT} where {TD, DT} | ||
| const CATKEVDArray{TD, DT} = AbstractArray{<:CATKEVD{TD, DT}} where {TD, DT} | ||
| const FlavorOfCATKE{TD, DT} = Union{CATKEVD{TD, DT}, CATKEVDArray{TD, DT}} where TD, DT |
There was a problem hiding this comment.
it's kind of a mess, is it worth it?
|
Right. It seems a bit complicated to make it work like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation may not be correct.
The sub stepping scheme is in principle different than the baroclinic stepping scheme so I am not extremely sure this method works. I ll think a bit more about it.
We actually need to implement it like we did for the
SplitExplicitFreeSurface, by saving down the slow tendencies, and averaging them in the last step. All stages should go fromnton+1.