Skip to content

Commit f8c4990

Browse files
get rid of hover wrapper
1 parent 85156b5 commit f8c4990

File tree

2 files changed

+8
-62
lines changed

2 files changed

+8
-62
lines changed

src/components/DateDetails/DateDetails.stories.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ export default {
2828
type: "select",
2929
},
3030
},
31-
useHoverTrigger: {
32-
control: "boolean",
33-
},
3431
},
3532
component: DateDetails,
3633
title: "Display/DateDetails",
@@ -43,7 +40,6 @@ export const Playground = {
4340
side: "top",
4441
systemTimeZone: undefined,
4542
title: "DateDetails",
46-
useHoverTrigger: false,
4743
},
4844
render: (args: Args) => {
4945
const date = args.date ? new Date(args.date) : new Date();
@@ -52,7 +48,6 @@ export const Playground = {
5248
date={date}
5349
side={args.side}
5450
systemTimeZone={args.systemTimeZone}
55-
useHoverTrigger={args.useHoverTrigger}
5651
/>
5752
);
5853
},

src/components/DateDetails/DateDetails.tsx

Lines changed: 8 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { Text } from "@/components/Typography/Text/Text";
1313
import { linkStyles, StyledLinkProps } from "@/components/Link/common";
1414
import { GridContainer } from "@/components/GridContainer/GridContainer";
1515
import { Container } from "@/components/Container/Container";
16-
import { PropsWithChildren, ReactElement, useState } from "react";
1716

1817
dayjs.extend(advancedFormat);
1918
dayjs.extend(duration);
@@ -102,69 +101,18 @@ const formatTimezone = (date: Dayjs, timezone?: string): string => {
102101
);
103102
};
104103

105-
interface PopoverWrapperProps extends PropsWithChildren {
106-
date: Date;
107-
useHoverTrigger?: boolean;
108-
}
109-
110-
const PopoverWrapper = ({
111-
children,
112-
date,
113-
useHoverTrigger,
114-
}: PopoverWrapperProps): ReactElement => {
115-
const [isOpen, setIsOpen] = useState<boolean>(false);
116-
117-
const handleMouseEnter = () => {
118-
setIsOpen(true);
119-
};
120-
121-
const handleMouseLeave = () => {
122-
setIsOpen(false);
123-
};
124-
125-
if (useHoverTrigger) {
126-
return (
127-
<Popover open={isOpen}>
128-
<UnderlinedTrigger
129-
$size="sm"
130-
$weight="medium"
131-
onMouseEnter={handleMouseEnter}
132-
onMouseLeave={handleMouseLeave}
133-
>
134-
<Text size="sm">{dayjs.utc(date).fromNow()}</Text>
135-
</UnderlinedTrigger>
136-
{children}
137-
</Popover>
138-
);
139-
}
140-
141-
return (
142-
<Popover>
143-
<UnderlinedTrigger
144-
$size="sm"
145-
$weight="medium"
146-
>
147-
<Text size="sm">{dayjs.utc(date).fromNow()}</Text>
148-
</UnderlinedTrigger>
149-
{children}
150-
</Popover>
151-
);
152-
};
153-
154104
export type ArrowPosition = "top" | "right" | "left" | "bottom";
155105

156106
export interface DateDetailsProps {
157107
date: Date;
158108
side?: ArrowPosition;
159109
systemTimeZone?: string;
160-
useHoverTrigger?: boolean;
161110
}
162111

163112
export const DateDetails = ({
164113
date,
165114
side = "top",
166115
systemTimeZone,
167-
useHoverTrigger = false,
168116
}: DateDetailsProps) => {
169117
const dayjsDate = dayjs(date);
170118

@@ -178,10 +126,13 @@ export const DateDetails = ({
178126
}
179127

180128
return (
181-
<PopoverWrapper
182-
date={date}
183-
useHoverTrigger={useHoverTrigger}
184-
>
129+
<Popover>
130+
<UnderlinedTrigger
131+
$size="sm"
132+
$weight="medium"
133+
>
134+
<Text size="sm">{dayjs.utc(date).fromNow()}</Text>
135+
</UnderlinedTrigger>
185136
<Popover.Content
186137
side={side}
187138
showArrow
@@ -243,6 +194,6 @@ export const DateDetails = ({
243194
</Container>
244195
</GridContainer>
245196
</Popover.Content>
246-
</PopoverWrapper>
197+
</Popover>
247198
);
248199
};

0 commit comments

Comments
 (0)