Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tabs names use more space #481

Open
serdec opened this issue Sep 23, 2024 · 5 comments
Open

Make tabs names use more space #481

serdec opened this issue Sep 23, 2024 · 5 comments
Assignees

Comments

@serdec
Copy link
Collaborator

serdec commented Sep 23, 2024

Description

image

Tabs names are truncated too soon. The tabs still have some space that could be used to show their name.

Possible solution

there could be two solutions for handling the close button (x) space

  1. adopting the same solution chrome does (do not show the x if the space is too little)
image image
  1. show the x as an absolute position on top of the label (we might need to give it a different background)
@guykoh
Copy link
Contributor

guykoh commented Sep 23, 2024

It's a bit funny we show this icon and not the name, should we drop the table icon when it's very narrow?
We should also make the tabs nav bar scrollable (horizontally - might be most beneficial for Mac users, so we definitely need to provide another solution). Another solution would be to add a dropdown button at the right end of the navbar where we can show all hidden open tabs.

wdyt @gjones, @fneves, @ArctypeZach?

@serdec
Copy link
Collaborator Author

serdec commented Sep 23, 2024

@guykoh the tabs are scrollable horizontally already

@guykoh
Copy link
Contributor

guykoh commented Sep 23, 2024

@guykoh the tabs are scrollable horizontally already

Should we show less open tabs in this case?

@serdec
Copy link
Collaborator Author

serdec commented Sep 23, 2024

that could also be an option, but i think the minimum width of the tab is already big enough, we would have to make it bigger

@fneves
Copy link
Collaborator

fneves commented Sep 26, 2024

Agree with serdec. Lets just increast the min width of each tab. Easiest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants