You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pulpdrew, sure, please feel free to do so.
I think the impl is more or less as follows:
We should have
role: string|Array<string>
added to BaseClickHouseClientConfigOptions (client-common/src/config.ts)
also add it to QueryParams, CommandParams, ExecParams, InsertParams (client-common/src/client.ts).
Similarly, it should be added to these interfaces' counterparts in the client-common/src/connection.ts.
Add roles to the toSearchParams fn in common/utils/url.ts
Finally, the Node.js client - pass roles to the toSearchParams fn in the client-node/src/connection/node_base_connection.ts; Web client - same in the client-web/src/connection/web_connection.
Probably not worth adding it to the URL configuration currently
Tests: this is the annoying part. Probably a separate file in the common pkg tests for all the possibilities (global, overrides from the query, exec, insert, command methods); maybe restrict it to the single node only for simplicity, cause there is quite a lot of bootstrap, and it's getting more complicated with a cluster.
In case of any questions, please feel free to contact me in the community Slack.
NB: in the case of just a single role now, the current workaround could be
See
role
query parameter to the HTTP interface ClickHouse#62669The text was updated successfully, but these errors were encountered: