Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for role query parameters #328

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Add support for role query parameters #328

merged 4 commits into from
Nov 5, 2024

Conversation

pulpdrew
Copy link
Contributor

Summary

This PR adds support for specifying roles via request query parameters. Closes #269.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

slvrtrn
slvrtrn requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@slvrtrn slvrtrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Tests are good, too. There is one thing that we should fix before merging (the example); the rest are mostly nitpicks

examples/role.ts Show resolved Hide resolved
examples/role.ts Show resolved Hide resolved
packages/client-common/__tests__/integration/role.test.ts Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/role.ts Show resolved Hide resolved
packages/client-common/__tests__/unit/to_search_params.test.ts Show resolved Hide resolved
packages/client-common/src/utils/url.ts Outdated Show resolved Hide resolved
@slvrtrn
Copy link
Contributor

slvrtrn commented Sep 26, 2024

The CLA also needs to be signed before we merge it.

@pulpdrew
Copy link
Contributor Author

The CLA also needs to be signed before we merge it.

Will do - I am working with my company to make sure I am not violating any of their open source policies by signing, but will sign as soon as I have approval.

@slvrtrn
Copy link
Contributor

slvrtrn commented Nov 1, 2024

@pulpdrew, do you have any updates regarding the CLA? I'd like to merge this, but non-signed CLA is a blocker.

@pulpdrew
Copy link
Contributor Author

pulpdrew commented Nov 1, 2024 •
edited
Loading

@pulpdrew, do you have any updates regarding the CLA? I'd like to merge this, but non-signed CLA is a blocker.

@slvrtrn Hey, apologies for the delay. My company is still reviewing the CLA. 🫠 They tell me they should have an update for me early next week. I will reply here with an ETA next week once I hear from them!

@pulpdrew
Copy link
Contributor Author

pulpdrew commented Nov 4, 2024

@slvrtrn I have signed the CLA, thanks for waiting!

@slvrtrn slvrtrn changed the base branch from main to role-params November 5, 2024 14:11
@slvrtrn slvrtrn merged commit f398782 into ClickHouse:role-params Nov 5, 2024
This was referenced Nov 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slvrtrn slvrtrn slvrtrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add role support via query parameters
3 participants
@pulpdrew @CLAassistant @slvrtrn