Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ClusterLabs/libqb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.8
Choose a base ref
...
head repository: ClusterLabs/libqb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 6 commits
  • 7 files changed
  • 4 contributors

Commits on Nov 15, 2023

  1. Change assert in ringbuffer to a return code (#492)

    Why just this one?
    
    There are LOADS of asserts in libqb, some are OK and some may be
    overkill. This one in particular is causing CI failures
    and so annoys me more than the rest.
    chrissie-c authored Nov 15, 2023
    Copy the full SHA
    9297df4 View commit details
  2. Copy the full SHA
    a3201f5 View commit details

Commits on Nov 20, 2023

  1. doxygen2man: Include libxml/parser.h (#494)

    This seems to be needed for newer versions of libxml
    but shouldn't break older ones (CI to confirm!)
    chrissie-c authored Nov 20, 2023
    1
    Copy the full SHA
    c752813 View commit details

Commits on Jan 31, 2024

  1. Make some logs less noisy (#495)

    * log: lower IPC connection issues to info level
    
    ... in handle_new_connection(). The caller has better context for whether a
    problem merits a warning or error, and the function's return code is
    sufficiently descriptive to do so. Some problems may be expected or able to be
    worked around.
    
    For example, Pacemaker's crm_mon attempts to contact pacemakerd IPC. On a
    Pacemaker Remote node, that IPC will be unavailable, and crm_mon can check the
    libqb return code to detect and handle that situation gracefully.
    
    * log: lower some ringbuffer debug messages to trace level
    
    They're rather noisy, with every shm-based IPC connection generating multiple
    obscure messages like:
    
      debug: shm size:1048589; real_size:1052672; rb->word_size:263168
    
    and every disconnect generating the rather unhelpful:
    
      debug: qb_ipcc_disconnect()
    
    along with multiple messages like:
    
      debug: Closing ringbuffer: /dev/shm/qb-10986-11014-34-26VRvs/qb-request-cmap-header
    
    All of these seem appropriate to trace level.
    kgaillot authored Jan 31, 2024
    Copy the full SHA
    1070cbc View commit details

Commits on May 18, 2024

  1. Copy the full SHA
    40542f3 View commit details

Commits on Aug 28, 2024

  1. Copy the full SHA
    4e7ebfa View commit details
Loading