Skip to content

changed the position of the button #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

changed the position of the button #16

merged 2 commits into from
May 22, 2024

Conversation

Tenkaklet
Copy link
Collaborator

@Tenkaklet Tenkaklet commented May 21, 2024

PR Type

enhancement, documentation


Description

  • Enhanced the overall styling of the application by adding global box-sizing and updating the body background with multiple images.
  • Improved the .container class with relative positioning and a background image with opacity.
  • Adjusted the input and button elements for better alignment and visual appeal.
  • Integrated Google Fonts for improved typography.
  • Updated the HTML structure to wrap the input and button in a div for better styling control.

Changes walkthrough 📝

Relevant files
Enhancement
styles.css
Enhanced styling for layout and background images.             

src/css/styles.css

  • Added global box-sizing rule.
  • Updated body background with images and positioning.
  • Enhanced .container with relative positioning and background image.
  • Adjusted input and button styles for better alignment.
  • +46/-11 
    index.html
    Integrated Google Fonts and improved input/button structure.

    src/index.html

  • Added Google Fonts preconnect and font link.
  • Wrapped input and button in a div for better styling.
  • +8/-3     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @Tenkaklet
    Copy link
    Collaborator Author

    re opening due to my morning, need more coffee.
    @andystoys + @JSCodes14
    approve this.

    @devtebaldi good job! keep working on the styling!

    @andystoys
    Copy link
    Contributor

    re opening due to my morning, need more coffee. @andystoys + @JSCodes14 approve this.

    @devtebaldi good job! keep working on the styling!

    Can you coordinate with @devtebaldi on these changes? He might have some other pending changes as well.

    @Tenkaklet
    Copy link
    Collaborator Author

    re opening due to my morning, need more coffee. @andystoys + @JSCodes14 approve this.
    @devtebaldi good job! keep working on the styling!

    Can you coordinate with @devtebaldi on these changes? He might have some other pending changes as well.

    When @devtebaldi sees this. Hopefully he'll get it working on it.

    @Tenkaklet
    Copy link
    Collaborator Author

    @devtebaldi are you satisfied with your work? Ok to merge it?

    @Tenkaklet Tenkaklet merged commit 8a36656 into main May 22, 2024
    @github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 22, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants