Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Should delete really delete? #17

Open
oguzhanaksoy opened this issue May 7, 2021 · 1 comment
Open

Discussion: Should delete really delete? #17

oguzhanaksoy opened this issue May 7, 2021 · 1 comment
Labels
discussion enhancement New feature or request
Milestone

Comments

@oguzhanaksoy
Copy link

oguzhanaksoy commented May 7, 2021

Let's say I am an analytics person and I would like to look at my history.
I would like to see what I have done 1 month/year ago.

If we really destroy the data/task from the database, we can't make the report.

I have 2 suggestion about this:

IsDeleted
In the tasks table, there can be a column, called IsDeleted --not very suggested

HISTask
We can create a new table, called HISTask (HistoryTask - it can be renamed) and we can have deleted date and updated date.
When we insert the task, we will insert it on HISTask too.
When we make reports about tasks, we will include HISTask on the query.

@pobiega pobiega changed the title Discussion: Is delete should really delete? Discussion: Should delete really delete? May 7, 2021
@pobiega pobiega added the enhancement New feature or request label May 7, 2021
@pobiega pobiega added this to the Post MVP milestone May 7, 2021
@pobiega
Copy link
Collaborator

pobiega commented May 7, 2021

First: I love this idea, and was going to suggest the same myself! :)

I suggest a hybrid between the approaches. "Column bloat" isn't really a problem in modern databases, so I'm fine with adding a fair bit.

Type Name
string Name
string Description
DateTime? DoneDate
DateTime? DeletedDate

Explanation of the DateTime? fields

A nullable DateTime can be used to show both if and when something happened. If its null, it is not done/deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants