settings: Turn on mypy checking.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: andersk

mypy.ini

@@ -40,12 +40,6 @@ warn_unreachable = True
 [mypy-conf]  # For docs/conf.py.
 ignore_errors = True
 
-[mypy-zproject.settings]
-ignore_errors = True
-
-[mypy-zproject.test_settings]
-ignore_errors = True
-
 # zerver.tornado.autoreload is a slightly-patched piece of upstream Tornado.
 [mypy-zerver.tornado.autoreload]
 ignore_errors = True

zproject/dev_settings.py

@@ -150,7 +150,7 @@
 THUMBOR_URL = 'http://127.0.0.1:9995'
 THUMBNAIL_IMAGES = True
 
-SEARCH_PILLS_ENABLED = os.getenv('SEARCH_PILLS_ENABLED', False)
+SEARCH_PILLS_ENABLED = bool(os.getenv('SEARCH_PILLS_ENABLED', False))
 
 BILLING_ENABLED = True
 

zproject/settings.py

@@ -14,6 +14,7 @@
 import os
 import time
 import sys
+from typing import Any, Dict, List, Union
 
 from zerver.lib.db import TimeTrackingConnection
 import zerver.lib.logging_util
@@ -147,7 +148,7 @@
 
 from django.template.loaders import app_directories
 class TwoFactorLoader(app_directories.Loader):
-    def get_dirs(self):
+    def get_dirs(self) -> List[str]:
         dirs = super().get_dirs()
         return [d for d in dirs if 'two_factor' in d]
 
@@ -211,8 +212,8 @@ def get_dirs(self):
 # Base URL of the Tornado server
 # We set it to None when running backend tests or populate_db.
 # We override the port number when running frontend tests.
-TORNADO_PROCESSES = int(get_config('application_server', 'tornado_processes', 1))
-TORNADO_SERVER = 'http://127.0.0.1:9993'
+TORNADO_PROCESSES = int(get_config('application_server', 'tornado_processes', '1'))
+TORNADO_SERVER = 'http://127.0.0.1:9993'  # type: Optional[str]
 RUNNING_INSIDE_TORNADO = False
 AUTORELOAD = DEBUG
 
@@ -270,7 +271,7 @@ def get_dirs(self):
     'OPTIONS': {
         'connection_factory': TimeTrackingConnection
     },
-}}
+}}  # type: Dict[str, Dict[str, Any]]
 
 if DEVELOPMENT:
     LOCAL_DATABASE_PASSWORD = get_secret("local_database_password")
@@ -449,7 +450,7 @@ def get_dirs(self):
                   'name': 'Welcome Bot'}]
 
 # Bots that are created for each realm like the reminder-bot goes here.
-REALM_INTERNAL_BOTS = []
+REALM_INTERNAL_BOTS = []  # type: List[Dict[str, str]]
 # These are realm-internal bots that may exist in some organizations,
 # so configure power the setting, but should not be auto-created at this time.
 DISABLED_REALM_INTERNAL_BOTS = [
@@ -545,7 +546,7 @@ def get_dirs(self):
 LOADERS = [
     'django.template.loaders.filesystem.Loader',
     'django.template.loaders.app_directories.Loader',
-]
+]  # type: List[Union[str, Tuple[object, ...]]]
 if PRODUCTION:
     # Template caching is a significant performance win in production.
     LOADERS = [('django.template.loaders.cached.Loader', LOADERS)]
@@ -564,7 +565,7 @@ def get_dirs(self):
             'django.template.context_processors.i18n',
         ],
     },
-}
+}  # type: Dict[str, Any]
 
 default_template_engine_settings = deepcopy(base_template_engine_settings)
 default_template_engine_settings.update({
@@ -874,7 +875,7 @@ def zulip_path(path: str) -> str:
             'propagate': False,
         },
     }
-}
+}  # type: Dict[str, Any]
 
 LOGIN_REDIRECT_URL = '/'
 

zproject/test_settings.py

@@ -119,7 +119,7 @@
         'BACKEND': 'django.core.cache.backends.locmem.LocMemCache'
     }
 
-    def set_loglevel(logger_name, level) -> None:
+    def set_loglevel(logger_name: str, level: str) -> None:
         LOGGING['loggers'].setdefault(logger_name, {})['level'] = level
     set_loglevel('zulip.requests', 'CRITICAL')
     set_loglevel('zulip.management', 'CRITICAL')
@@ -215,6 +215,5 @@ def set_loglevel(logger_name, level) -> None:
         "attr_username": "email",
         "attr_email": "email",
         "display_name": "Test IdP",
-        "display_icon": None,
     }
 }