Skip to content

Commit 8f3a092

Browse files
hackerkidtimabbott
authored andcommitted
lint: Ban color names in CSS.
We already lint using HSL rather than RGB consistently.
1 parent f1ae0e2 commit 8f3a092

File tree

6 files changed

+15
-14
lines changed

6 files changed

+15
-14
lines changed

.stylelintrc

+1
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,6 @@
6262

6363
# Limit language features
6464
"color-no-hex": true,
65+
"color-named": "never",
6566
}
6667
}

static/styles/compose.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ div[id^="message-edit-send-status"],
265265
font-size: 17px;
266266
font-weight: bold;
267267
color: hsl(0, 0%, 0%);
268-
text-shadow: 0 1px 0 white;
268+
text-shadow: 0 1px 0 hsl(0, 0%, 100%);
269269
opacity: .2;
270270
filter: alpha(opacity=20);
271271
float: right;
@@ -303,7 +303,7 @@ div[id^="message-edit-send-status"],
303303
font-size: 17px;
304304
font-weight: bold;
305305
color: hsl(0, 0%, 0%);
306-
text-shadow: 0 1px 0 white;
306+
text-shadow: 0 1px 0 hsl(0, 0%, 100%);
307307
opacity: .2;
308308
filter: alpha(opacity=20);
309309
}

static/styles/night_mode.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ body.night-mode {
6262
/* this one makes the border of the reactions highlighted on hovering. */
6363
.message_reaction:hover,
6464
.reaction_button:hover {
65-
border-color: white !important;
65+
border-color: hsl(0, 0%, 100%) !important;
6666
}
6767

6868
/* do not turn the .message_header .stream_label text dark on hover because they're

static/styles/portico.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ img.screenshot {
496496
.integration {
497497
margin-top: 2em;
498498
padding-top: 1em;
499-
border-top: 1px dashed black;
499+
border-top: 1px dashed hsl(0, 0%, 0%);
500500
}
501501

502502
.integration p {
@@ -1005,7 +1005,7 @@ a.bottom-signup-button {
10051005

10061006
.team input:checked + label {
10071007
border: 1px solid hsl(0, 0%, 93%);
1008-
border-top: 2px solid yellowgreen;
1008+
border-top: 2px solid hsl(80, 61%, 50%);
10091009
border-bottom-color: hsl(0, 0%, 100%);
10101010
}
10111011

templates/zerver/emails/email.css

+8-8
Original file line numberDiff line numberDiff line change
@@ -185,14 +185,14 @@ a.button:hover {
185185

186186
.recipient_block {
187187
background-color: #f0f4f5;
188-
border: 1px solid black;
188+
border: 1px solid #000000;
189189
margin-bottom: 4px;
190190
}
191191

192192
.recipient_header {
193193
color: #e0dada;
194194
background-color: #444444;
195-
border-bottom: 1px solid black;
195+
border-bottom: 1px solid #000000;
196196
font-weight: bold;
197197
padding: 2px;
198198
}
@@ -221,13 +221,13 @@ a.button:hover {
221221
}
222222

223223
.hot_convo_recipient_block {
224-
border: 1px solid black;
224+
border: 1px solid #000000;
225225
margin-bottom: 4px;
226226
}
227227

228228
.hot_convo_recipient_header {
229229
background-color: #9ec9ff;
230-
border-bottom: 1px solid black;
230+
border-bottom: 1px solid #000000;
231231
font-weight: bold;
232232
padding: 2px;
233233
}
@@ -243,13 +243,13 @@ a.button:hover {
243243
}
244244

245245
.recipient_block_with_messages {
246-
border: 1px solid black;
246+
border: 1px solid #000000;
247247
margin-bottom: 4px;
248248
}
249249

250250
.recipient_header_with_messages {
251251
background-color: #9ecaff;
252-
border-bottom: 1px solid black;
252+
border-bottom: 1px solid #000000;
253253
font-weight: bold;
254254
padding: 2px;
255255
}
@@ -261,14 +261,14 @@ a.button:hover {
261261

262262
.recipient_block_without_messages {
263263
background-color: #f0f4f5;
264-
border: 1px solid black;
264+
border: 1px solid #000000;
265265
margin-bottom: 4px;
266266
}
267267

268268
.recipient_header_without_messages {
269269
color: #ffffff;
270270
background-color: #444444;
271-
border-bottom: 1px solid black;
271+
border-bottom: 1px solid #000000;
272272
font-weight: bold;
273273
padding: 2px;
274274
}

version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
# Typically, adding a dependency only requires a minor version bump, and
1212
# removing a dependency requires a major version bump.
1313

14-
PROVISION_VERSION = '27.1'
14+
PROVISION_VERSION = '27.2'

0 commit comments

Comments
 (0)