Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.4 #118

Open
WaterSpout opened this issue Jan 25, 2017 · 1 comment
Open

Laravel 5.4 #118

WaterSpout opened this issue Jan 25, 2017 · 1 comment

Comments

@WaterSpout
Copy link

Please, add Laravel 5.4 support
I found one error to vendor/codesleeve/laravel-stapler/src/Providers/ServiceProvider.php file on 58 line, need will remove second param to closure function

@Patroklo
Copy link
Contributor

Patroklo commented Mar 8, 2017

Hi! Add this to your L5ServiceProvider. Well... it's better to make your own Provider extending the L5. But you get the idea.

EDIT: This exception appears in my installation only in the php artisan commands given that the problem it's in a command.

use Codesleeve\LaravelStapler\Services\ImageRefreshService;

......
    /**
     * Register the image refresh service with the container.
     */
    protected function registerImageRefreshService()
    {
        $this->app->singleton('ImageRefreshService', function ($app)
        {
            return new ImageRefreshService($app);
        });
    }

This should do the trick. The only change from the original code it's that I have deleted a parameter in the return new ImageRefreshService($app); But I don't know if it would be ok to send the changes as a pull request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants