Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if mime_content_type is available and show notification #909

Closed
vytisbulkevicius opened this issue Mar 29, 2024 · 2 comments · Fixed by #912 or #925
Closed

Check if mime_content_type is available and show notification #909

vytisbulkevicius opened this issue Mar 29, 2024 · 2 comments · Fixed by #912 or #925
Assignees
@preda-bogdan
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@vytisbulkevicius
Copy link
Contributor

Description

From the uninstallation feedback we found that there was a mention of critical error:

critical uncaught error Critical Uncaught Error: Call to undefined function mime_content_type() in /plugins/feedzy-rss-feeds/includes/admin/feedzy-rss-feeds-import.php:1979

It can happen on websites that don't have mime_content_type enable on the server but we should check this without generating a critical error on the website on those cases and showing to user that it should be enabled for Feedzy to work.

Should have been introduced here - 6ceb36f

Step-by-step reproduction instructions

Can be replicated by disabling mime_content_type on the server.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@vytisbulkevicius vytisbulkevicius added bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. labels Mar 29, 2024
@preda-bogdan preda-bogdan added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Mar 29, 2024
preda-bogdan added a commit that referenced this issue Mar 29, 2024
@preda-bogdan
fix: guard against missing function
aa6ce06 
Closes: #909
@preda-bogdan preda-bogdan linked a pull request Mar 29, 2024 that will close this issue
Fix/mime content type #912
Merged
6 tasks
@preda-bogdan preda-bogdan mentioned this issue Mar 29, 2024
Merged
6 tasks
@preda-bogdan
Copy link
Contributor

Added a way to retrieve the mime type from the headers of the file and will use the mime_content_type only if is present in the environment of the user.

@vytisbulkevicius vytisbulkevicius linked a pull request Apr 10, 2024 that will close this issue
Release #925
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preda-bogdan preda-bogdan

Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/mime content type Codeinwp/feedzy-rss-feeds
Release Codeinwp/feedzy-rss-feeds
3 participants
@preda-bogdan @vytisbulkevicius @pirate-bot