Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some images are not set as featured when % is in the img src url. #917

Closed
tio-trom opened this issue Apr 6, 2024 · 3 comments · Fixed by #923 or #925
Closed

Some images are not set as featured when % is in the img src url. #917

tio-trom opened this issue Apr 6, 2024 · 3 comments · Fixed by #923 or #925
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@tio-trom
Copy link

tio-trom commented Apr 6, 2024

Description

I noticed that with the following feed - https://fetchrss.com/rss/64e0dbc093190f2b1a5d40b264e22cf23a76e05a277d6673.xml

This one embeds an image for the post content and also imports it into the media library and thus sets it up as a featured image:

<item>
<title>The rich and the poor</title>
<link>
https://www.cartoonmovement.com/cartoon/rich-and-poor-7
</link>
<description>
<img src="http://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/large/s3/IMG_2526.jpeg?itok=cQk0peCM" width="480" height="309"><br><br><br/><br/><span style="font-size:12px; color: gray;">(Feed generated with <a href="https://fetchrss.com" target="_blank">FetchRSS</a>)</span>
</description>
<dc:creator>Rahma Cartoons</dc:creator>
<pubDate>Fri, 05 Apr 2024 23:14:22 +0000</pubDate>
<media:content url="http://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/large/s3/IMG_2526.jpeg?itok=cQk0peCM" medium="image" width="480" height="309"/>
<guid isPermaLink="false">
https://www.cartoonmovement.com/cartoon/rich-and-poor-7
</guid>
</item>

This one only embeds the image into the post but cannot import it into the media library, and this cannot set it up as a featured image:

<item>
<title>
overflowing wealth We want a wealth tax on Europe's richest.
</title>
<link>
https://www.cartoonmovement.com/cartoon/overflowing-wealth
</link>
<description>
<img src="http://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/large/s3/909%20-Saeed%2020%20Jan%20%202012%20-2.jpg?itok=9qzmqslM" width="480" height="679"><br><br><p>We want a wealth tax on Europe's richest.</p><br/><br/><span style="font-size:12px; color: gray;">(Feed generated with <a href="https://fetchrss.com" target="_blank">FetchRSS</a>)</span>
</description>
<dc:creator>Saeed Sadeghi</dc:creator>
<pubDate>Fri, 05 Apr 2024 23:14:22 +0000</pubDate>
<media:content url="http://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/large/s3/909%20-Saeed%2020%20Jan%20%202012%20-2.jpg?itok=9qzmqslM" medium="image" width="480" height="679"/>
<guid isPermaLink="false">
https://www.cartoonmovement.com/cartoon/overflowing-wealth
</guid>
</item>

So it is on and off for a bunch of them. Looking at the code the only pattern I see is that it works to import into the wordpress library the photos that do not contain % symbols in the img scr. These are normally spaces in the URL.

Please check if you can.

Step-by-step reproduction instructions

As described above.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

@tio-trom tio-trom added the bug This label could be used to identify issues that are caused by a defect in the product. label Apr 6, 2024
@vytisbulkevicius
Copy link
Contributor

Thanks for reporting this @tio-trom.
Indeed, in the Error log I see that those characters are the problem and they are converted to space so image becomes invalid:
image

We will look into fixing it.

@vytisbulkevicius vytisbulkevicius added the Priority-Medium Expected resolution time - up to 1 month. label Apr 6, 2024
@preda-bogdan preda-bogdan added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Apr 7, 2024
@preda-bogdan preda-bogdan linked a pull request Apr 10, 2024 that will close this issue
6 tasks
@vytisbulkevicius vytisbulkevicius linked a pull request Apr 10, 2024 that will close this issue
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
@tio-trom
Copy link
Author

The issue is solved but I think I caught one more - https://s3-eu-central-1.amazonaws.com/cartoons-s3/styles/product_detail_image/s3/%C3%A7%C3%B6p.jpg?itok=ZYU_ihPB special characters like

2024-04-11_06-04

That I cannot even copy here. But follow the link please. They too cannot be added to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. Priority-Medium Expected resolution time - up to 1 month. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
4 participants