Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review limit setting behaviour and allow usage in tandem with the Retina #767

Open
selul opened this issue Jan 15, 2024 · 6 comments
Open
Labels
new feature Request for a new feature or functionality to be added to the project.
Milestone

Comments

@selul
Copy link
Contributor

selul commented Jan 15, 2024

What problem does this address?

Right now if the Limit setting behavior is on, the retina option can not be used, this being the default behavior.

We added this to prevent when the dpr size is exceeding the limit in this case, however this is bringing a loss in quality for the images for customers that prefer a best image quality within the constrain of web vitals.

I got this request from various customers that complained about their issue with image compression and after enabling the DPR they were happy with the quality.

What is your proposed solution?

I would suggest disconnecting those settings dependecnies and apply the limit to the size before DPR like is doing right now, however leaving the DPR factor to be applied.

Moreover, we can also enable the DPR factor aswell by default.

@kushh23 @abaicus curious if you have any feedback.

Will this feature require documentation? (Optional)

None

@selul selul added the new feature Request for a new feature or functionality to be added to the project. label Jan 15, 2024
@selul selul added this to the 4.0 milestone Jan 15, 2024
@abaicus
Copy link
Contributor

abaicus commented Jan 16, 2024

I think disconnecting the two settings is a good idea. I believe allowing the user to decide if they want retina images delivered is better, even if they want to limit their maximum size. 👍🏻

@kushh23
Copy link

kushh23 commented Jan 16, 2024

I agree with you that it is creating confusion for the users as the Limit settings are turned on by default on the first install, and due to this, retina is disabled, hence resulting nonretina images site, which sometimes looks blurry. Many users have asked why the retina is not working, and the reason is limit size option being on. By disconnecting those two settings, we can avoid this confusion.

@kushh23
Copy link

kushh23 commented Jan 16, 2024

is this already implemented in v3.12.3 release today?

@abaicus
Copy link
Contributor

abaicus commented Jan 16, 2024

@kushh23 no, it is not implemented in today's release.

@kushh23
Copy link

kushh23 commented Jan 16, 2024

@abaicus Okay, thanks for the information. I read the message on slack about the release, so got confused.

@ineagu
Copy link
Contributor

ineagu commented Apr 10, 2024

thanks for linking the issues @kushh23. Personally I enable retina on the sites we are using and for me it can be enabled by default since there is a big difference in UX.

Also I won't use the limit image sizes myself since we can already use the WordPress setting to load an image at a lower size if this is what we want, so I am not sure why this is enabled by default or why it exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
Development

No branches or pull requests

4 participants