-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for templates save for FSE Editor. #248
Comments
Not a priority but will appreciate how you see this working whenever you have time to think about it @Codeinwp/design-team |
This is a good idea. Not sure if Core plans to add a flow for this directly in FSE. |
@mghenciu not so sure about the hierarchy here. I think these FSE templates should be available only under the Gutenberg tab, and not at the top level tabs 🤔 I am not sure if what bogdan said "...save FSE template data under a global option instead of the post meta, just for the FSE templates..." is related to the actual UI or it's a technical/code thing. Will take a look as well and let you know, it's a bit tricky. |
@JohnPixle @mghenciu At this point, we can maybe consider renaming Gutenberg to Block Editor to avoid this confusion and the FSE theme being part of "FSE Theme" based on if the user is currently using an FSE theme. |
I am not sure about renaming the Gutenberg tab to Block Editor or something FSE related. 🤔 My suggestion is to simply include the FSE templates in the patterns under the GB tab, and perhaps:
Also, what happens in the case when a user is not using an FSE theme? Do we still show the FSE templates? |
@JohnPixle I would hide the FSE templates if the theme being used is not FSE. I like the idea of a toggle and using tags to differentiate them, and I agree that just having them under the Gutenberg tab should be enough as to not create more confusion. They are basically using the same editor but within a different context. For users that don't have FSE it will look the same, for the ones that have an FSE theme they will get some additional templates displayed. |
sorry for the late replay. And I wanted to mention that this issue refers to the save for FSE Editor in Templates Cloud. An action that it's usually taken by the user, so assume if they are using this feature of Save/Import -> then it's a FSE site. @JohnPixle, what do you think if we reuse the same design from demosites.io, bu instead of PRO we write FSE with #325ce8? Based on how My Library pages look now (attached below), I think it will fit well: Later we can see how and when we'll add FSE templates as Page Templates. |
If we take this approach, then I think we should differentiate the FSE tag at least with the color. It's too similar with the PREMIUM tag right now imo. |
@preda-bogdan proposed to hide the FSE templates, if the user is not Using an FSE theme. Just wanted to confirm we are all on the same page here 🤔 |
Thanks for the input here @mghenciu
@preda-bogdan Can we do that technically?
We can communicate something like: Or something like that. Which can appear once. |
@JohnPixle yes, it can be done, if you decide we want to show them with a disabled state for when an FSE theme is not active it should be possible. |
Ok, Let's move on with having them displayed but disabled. If you need any further help on this @preda-bogdan, don't hesitate to ping me. |
@preda-bogdan Do you need any further design work in order to proceed with integrating this? I understand that if we want to have a message in a popup, we will need the proper copy. I will work on that. Let me know! |
@preda-bogdan I am back with a follow-up on this. Popup to let users know about the FSE additionThe first time users open the library after the update, we should give them a heads-up that they can now save FSE templates. The learn-more link takes them to the related doc (in case we have one). Library UI changesI am suggesting three changes here:
@mghenciu Feel free to share you input here if you have some. Regarding the positioning of the tags, eventually I discovered that there are no cases for a "Premium" tag in parallel. This tag only happens on Starter sites, not templates. |
Make sense, @JohnPixle . We can review the tag position later if there would be any Pro Templates. And regarding the badge position, what do you think if we add it on the right side? this way it will be in the same place all the time, even with a longer name: Also note that this should work in the List view, which is available in the settings page. I wanted to ask also if we have now (if not - I think we should) the Top TPC icon that allows saving pages. Right now it's not visible on the Neve FSE demo: |
@mghenciu great ideas, thanks so much! I left your version on the board, let's go with how you suggest.
I think Bogdan may help with this, I think it should be possible (hopefully) |
@HardeepAsrani @preda-bogdan 👋🏻 We have set the design status as "Ready for Dev" for this one, you may proceed with it and let us know if you have any Qs or need clarifications! Thanks! |
What problem does this address?
Currently, there is no support to save FSE templates from within the
site-editor
as the save feature relies on the postType being defined. Hence the template save is disabled as a result of #246What is your proposed solution?
We would need to improve support for the FSE editor and save FSE template data under a global option instead of the post meta, just for the FSE templates.
Also, we would need to check the import workflow and use another type
site-editor
instead ofgutenberg
to differentiate FSE templates from regular templates.Figma
The text was updated successfully, but these errors were encountered: