Skip to content

[TransitionHelper] CancellationTokenSource is disposable and needs handling for clean-up #407

Open
@michael-hawker

Description

@michael-hawker

Issue with an inner disposable reference that needs to be cleaned up by the parent class to avoid the C# compiler warning:

 D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\src\TransitionHelper.Animation.cs(30,29): error CA1001: Type 'TransitionHelper' owns disposable field(s) '_currentAnimationCancellationTokenSource' but is not disposable [D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\src\CommunityToolkit.Labs.WinUI.TransitionHelper.csproj]

For now this is ignored. Not sure how we want to handle this as it is a resourced helper...

Originally posted by @michael-hawker in #354 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    experiment 🧪Used to track issues that are experiments (or their linked discussions)issue 🧪Used for tracking an Issue/Bug/Feature of an open Experiment/Component

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions