Skip to content

Inconsistent Package Identities #661

Open
@michael-hawker

Description

@michael-hawker

Describe the bug

The following are missing .Controls. in their Package Ids:

  • OpacityMaskView
  • Ribbon
  • TitleBar

i.e. they're missing this

<PackageId>$(PackageIdPrefix).$(PackageIdVariant).Controls.$(ToolkitComponentName)</PackageId>

This breaks the links to the packages in ADO from the Sample App with CommunityToolkit/Tooling-Windows-Submodule#275

There are other larger inconsistencies here we should investigate fixing for 8.3.

Ideally, all projects and namespaces are simple and aligned to the practices we have in the main repo (no Labs). Only thing that has Labs is the PackageId for when pushed to NuGet feeds.

Steps to reproduce

-

Expected behavior

Sample App can link to these packages consistently based on project name pattern it has access to.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

🔖 Ready

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions