Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many dependecy for EnergyHistogramData data reader #3914

Open
PrometheusPi opened this issue Nov 16, 2021 · 2 comments
Open

too many dependecy for EnergyHistogramData data reader #3914

PrometheusPi opened this issue Nov 16, 2021 · 2 comments
Labels
bug a bug in the project's code component: plugin in PIConGPU plugin component: tools scripts, python libs and CMake

Comments

@PrometheusPi
Copy link
Member

PrometheusPi commented Nov 16, 2021

If loading the python module EnergyHistogramData, shipped with picongpu, via:

from picongpu.plugins.data import EnergyHistogramData

the module imageio (perhaps also pandas?) is required. Since this is only a data reader, no image processing library should be required. Perhaps this is a simple error in include order since the visualization module:

from picongpu.plugins.plot_mpl import EnergyHistogramMPL

To avoid conflicts for new users, this could be fixed - but in my opinion has a low priority.

EDIT:
The error is more severe - loading EnergyHistogramData loads all other modules and thus all other dependencies (not needed for this simple module) need to be installed.

/.../picongpu/lib/python/picongpu/plugins/data/__init__.py in <module>
      2 from .phase_space import PhaseSpaceData
      3 from .png import PNGData
----> 4 from .radiation import RadiationData
      5 from .sliceFieldReader import FieldSliceData
      6 from .emittance import EmittanceData

I would consider this a bug - I will have to cross check this against the most up to date dev.

@PrometheusPi PrometheusPi added component: plugin in PIConGPU plugin component: tools scripts, python libs and CMake labels Nov 16, 2021
@PrometheusPi PrometheusPi changed the title imageio dependecy for EnergyHistogramData data reader too many dependecy for EnergyHistogramData data reader Nov 16, 2021
@PrometheusPi PrometheusPi added the bug a bug in the project's code label Nov 16, 2021
@PrometheusPi
Copy link
Member Author

@psychocoderHPC might need a back-port to the release candidate

@PrometheusPi
Copy link
Member Author

The issue still exists after @s9105947 restructuring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the project's code component: plugin in PIConGPU plugin component: tools scripts, python libs and CMake
Projects
None yet
Development

No branches or pull requests

1 participant