Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Naming in SimulationHelperField #4292

Open
BrianMarre opened this issue Sep 13, 2022 · 0 comments
Open

Inconsistent Naming in SimulationHelperField #4292

BrianMarre opened this issue Sep 13, 2022 · 0 comments
Assignees
@BrianMarre
Labels
good first issue signal new contributors where they can start refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@BrianMarre
Copy link
Member

BrianMarre commented Sep 13, 2022 •
edited
Loading

The naming distinction of CellDescription and mappingDesc in <pmacc/fields/SimulationHelperField> is not consistent,

both describe practically the same thing but their name suggest a difference.
@steindev steindev added refactoring code change to improve performance or to unify a concept but does not change public API good first issue signal new contributors where they can start labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianMarre BrianMarre

Labels
good first issue signal new contributors where they can start refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steindev @BrianMarre