Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Upgrade for conduit-ui #1005

Closed
1 task
jayjayjpg opened this issue Apr 17, 2023 · 4 comments · Fixed by #1011
Closed
1 task

Ember Upgrade for conduit-ui #1005

jayjayjpg opened this issue Apr 17, 2023 · 4 comments · Fixed by #1011
Labels
bug Something isn't working
Milestone

Comments

@jayjayjpg
Copy link
Contributor

jayjayjpg commented Apr 17, 2023

Bug description

Description

In order to keep up with security vulnerabilities more easily, we should upgrade Ember and it's related dependencies, such as ember-cli, ember-data, as well as version-dependent addons, e.g. ember-auto-import, ember-changeset, etc. to either

Blockers

This is a list of blockers that we encountered during the upgrade (tbd, once https://github.com/meroxa/platform-ui-v1/issues/881 had been worked through):

  • Build error @babel/template placeholder "SAMPLE_FEATURE_FLAG": Expected string substitution
@jayjayjpg jayjayjpg added bug Something isn't working triage Needs to be triaged labels Apr 17, 2023
@simonl2002
Copy link
Member

@jayjayjpg are you doing this work?

@simonl2002
Copy link
Member

@jayjayjpg is focussed elsewhere and thus will not be tackling this ember upgrade work. For now we will push this work until the next version of Conduit after 0.7.0.

@simonl2002 simonl2002 added this to the 1.0 milestone Apr 25, 2023
@simonl2002 simonl2002 removed the triage Needs to be triaged label Apr 25, 2023
@simonl2002 simonl2002 removed the status in Conduit Main Apr 25, 2023
@jayjayjpg
Copy link
Contributor Author

jayjayjpg commented Apr 26, 2023

@simonl2002 I just timeboxed exploration for half an hour to see how much effort it would be to upgrade to at least 4.8 (the latest LTS version of Ember that still receives security patches until December 2023) as I mentioned briefly before and will close this ticket if the tests for this PR pass

I can create a follow-up ticket for the final upgrade to 4.12 which could be tackled in a future Conduit release (e.g. 0.7.0)

The timeboxed PR can be found here: #1011

@jayjayjpg
Copy link
Contributor Author

I created this follow-up ticket for the missing part of the upgrade: #1012

@simonl2002 simonl2002 modified the milestones: 1.0, 0.7.0 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants