Skip to content

What's the line between shill and information #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaals opened this issue Feb 28, 2025 · 1 comment
Open

What's the line between shill and information #457

chaals opened this issue Feb 28, 2025 · 1 comment

Comments

@chaals
Copy link

chaals commented Feb 28, 2025

Reviewing a handful of PRs for adding things (because I also want to add some things), it seems some of them provide marketing copy that isn't really informative.

What's acceptable in terms of saying why something is good, and what is rejected as just marketing?

@pi0neerpat
Copy link
Contributor

Which ones are marketing? I usually determine if a change is valid with:

  • Useful for developers or people learning
  • More than a simple weekend project
  • Has some "staying" power

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants