Merge pull request #368 from ConsenSys/develop

v0.10.0 placeholder

Author: gbotrel

.github/workflows/pr.yml

@@ -1,5 +1,5 @@
 on: pull_request
-env: 
+env:
   GOPROXY: "https://proxy.golang.org"
 
 name: pull_request
@@ -10,7 +10,7 @@ jobs:
     - name: install Go
       uses: actions/setup-go@v2
       with:
-        go-version: 1.19.x
+        go-version: 1.20.x
     - name: checkout code
       uses: actions/checkout@v2
       with:
@@ -39,11 +39,11 @@ jobs:
         git update-index --assume-unchanged go.mod
         git update-index --assume-unchanged go.sum
         if [[ -n $(git status --porcelain) ]]; then echo "git repo is dirty after runing go generate -- please don't modify generated files"; echo $(git diff);echo $(git status --porcelain); exit 1; fi
-  
+
   test:
     strategy:
       matrix:
-        go-version: [1.18.x, 1.19.x]
+        go-version: [1.19.x, 1.20.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     needs:
@@ -72,12 +72,12 @@ jobs:
         go test -p=1 -v -timeout=30m ./...
         go test -p=1 -tags=purego -v -timeout=30m ./...
     - name: Test (32 bits & race)
-      if: (matrix.os == 'ubuntu-latest') && (matrix.go-version == '1.18.x')
+      if: (matrix.os == 'ubuntu-latest') && (matrix.go-version == '1.19.x')
       run: |
           go test -p=1 -v -timeout=30m -short -race  ./ecc/bn254/...
           go test -p=1 -v -timeout=30m -short -tags=noadx  ./ecc/bn254/...
           GOARCH=386 go test -p=1 -timeout=30m -short -v  ./ecc/bn254/...
-  
+
   slack-workflow-status-failed:
     if: failure()
     name: post workflow status to slack

README.md

@@ -38,7 +38,7 @@
 
 ### Go version
 
-`gnark-crypto` is tested with the last 2 major releases of Go (1.17 and 1.18).
+`gnark-crypto` is tested with the last 2 major releases of Go (currently 1.19 and 1.20).
 
 ### Install `gnark-crypto`
 

ecc/bls12-377/bls12-377.go

@@ -40,7 +40,8 @@ import (
 // ID bls377 ID
 const ID = ecc.BLS12_377
 
-// bCurveCoeff b coeff of the curve Y²=X³+b
+// aCurveCoeff is the a coefficients of the curve Y²=X³+ax+b
+var aCurveCoeff fp.Element
 var bCurveCoeff fp.Element
 
 // twist
@@ -97,7 +98,7 @@ type E6 = fptower.E6
 type E12 = fptower.E12
 
 func init() {
-
+	aCurveCoeff.SetUint64(0)
 	bCurveCoeff.SetUint64(1)
 	// D-twist
 	twist.A1.SetUint64(1)
@@ -148,3 +149,8 @@ func Generators() (g1Jac G1Jac, g2Jac G2Jac, g1Aff G1Affine, g2Aff G2Affine) {
 	g2Jac = g2Gen
 	return
 }
+
+// CurveCoefficients returns the a, b coefficients of the curve equation.
+func CurveCoefficients() (a, b fp.Element) {
+	return aCurveCoeff, bCurveCoeff
+}