feat: remove sanity check in generator (#1087)

DavePearce · web-flow · commit cfe21d67a5ea · 2025-08-06T14:03:55.000+12:00
remove sanity check in generator

This removes a sanity check that was preventing computed and
non-computed columns from being unioned together.
diff --git a/pkg/cmd/generate/union.go b/pkg/cmd/generate/union.go
@@ -136,8 +136,6 @@ func unionColumn(module string, left corset.SourceColumn, right corset.SourceCol
 	} else if left.Multiplier != right.Multiplier {
 		panic(fmt.Sprintf("inconsistent multiplier for column %s.%s (%d vs %d)",
 			module, left.Name, left.Multiplier, right.Multiplier))
-	} else if left.Computed != right.Computed {
-		panic(fmt.Sprintf("inconsistent kind for column %s.%s (computed vs not computed)", module, left.Name))
 	}
 	//
 	if left.Bitwidth >= right.Bitwidth {

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,6 @@ func unionColumn(module string, left corset.SourceColumn, right corset.SourceCol`
`136`	`136`	`} else if left.Multiplier != right.Multiplier {`
`137`	`137`	`panic(fmt.Sprintf("inconsistent multiplier for column %s.%s (%d vs %d)",`
`138`	`138`	`module, left.Name, left.Multiplier, right.Multiplier))`
`139`		`- } else if left.Computed != right.Computed {`
`140`		`- panic(fmt.Sprintf("inconsistent kind for column %s.%s (computed vs not computed)", module, left.Name))`
`141`	`139`	`}`
`142`	`140`	`//`
`143`	`141`	`if left.Bitwidth >= right.Bitwidth {`