Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split Path into AbsolutePath and RelativePath #503

Open
DavePearce opened this issue Jan 8, 2025 · 0 comments
Open

chore: split Path into AbsolutePath and RelativePath #503

DavePearce opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented Jan 8, 2025

The goal here is to make it clear when an absolute path is being used. There are some challenges in making this work, but largely it should be possible. There is also one potential benefit from this as well:

  • (virtual / non-virtual components). For an absolute path, it would be useful to distinguish the "virtual" segments from the non-virtual segments. This would allow us to generate a valid context directly from an absolute path, rather than carrying around the context separately.

From a terminology perspective, we could call them: static vs dynamic or outer vs inner, etc. They do remind me somehow of Java inner classes.

For a relative path, separating the virtual and non-virtual components perhaps doesn't matter since we cannot use this information anyway.

@DavePearce DavePearce added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant