Skip to content

Prover v5/bubble up the base fee and coin base #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 298 commits into
base: prover/dynamic-chain-config-mainnet
Choose a base branch
from

feat(exec) : adds the baseFee and the coinBase to the public inputs o…

ebc3f25
Select commit
Loading
Failed to load commit list.
Open

Prover v5/bubble up the base fee and coin base #1640

feat(exec) : adds the baseFee and the coinBase to the public inputs o…
ebc3f25
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Oct 28, 2025 in 1s

56 new alerts including 4 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 4 high
  • 1 medium

Other Alerts:

  • 5 errors
  • 23 warnings
  • 23 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 97 in bridge-ui/src/components/bridge/destination-address/index.tsx

See this annotation in the file changed.

Code scanning / CodeQL

DOM text reinterpreted as HTML High

DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.

Check warning on line 187 in bridge-ui/test/advancedFixtures.ts

See this annotation in the file changed.

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.

Check notice on line 32 in contracts/scripts/operational/tasks/setVerifierAddressTask.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable deployer.

Check warning on line 316 in prover/maths/common/smartvectors/arithmetic_basic.go

See this annotation in the file changed.

Code scanning / CodeQL

Unreachable statement Warning

This statement is unreachable.

Check failure on line 94 in prover/protocol/coin/coin.go

See this annotation in the file changed.

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
Loading
to a lower bit size type int without an upper bound check.

Check failure on line 98 in prover/protocol/coin/coin.go

See this annotation in the file changed.

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
Loading
to a lower bit size type int without an upper bound check.

Check failure on line 117 in prover/protocol/column/status.go

See this annotation in the file changed.

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
Loading
to a lower bit size type int without an upper bound check.

Check failure on line 121 in prover/protocol/column/status.go

See this annotation in the file changed.

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
Loading
to a lower bit size type int without an upper bound check.

Check notice on line 21 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/config/LineaTransactionPoolValidatorConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "deniedAddresses" does not match any actual parameter of method "toString()".
@param tag "deniedAddresses" does not match any actual parameter of method "build()".
@param tag "deniedAddresses" does not match any actual parameter of method "txPoolSimulationCheckP2pEnabled()".
@param tag "deniedAddresses" does not match any actual parameter of method "txPoolSimulationCheckApiEnabled()".
@param tag "deniedAddresses" does not match any actual parameter of method "maxTxCalldataSize()".
@param tag "deniedAddresses" does not match any actual parameter of method "maxTxGasLimit()".
@param tag "deniedAddresses" does not match any actual parameter of method "bundleDeniedAddresses()".
@param tag "deniedAddresses" does not match any actual parameter of method "toBuilder()".
@param tag "deniedAddresses" does not match any actual parameter of method "bundleOverridingDenyListPath()".
@param tag "deniedAddresses" does not match any actual parameter of method "builder()".
@param tag "deniedAddresses" does not match any actual parameter of method "denyListPath()".
@param tag "deniedAddresses" does not match any actual type parameter of type "LineaTransactionPoolValidatorConfigurationBuilder".
@param tag "deniedAddresses" does not match any actual parameter of constructor "LineaTransactionPoolValidatorConfigurationBuilder()".

Check notice on line 22 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/config/LineaTransactionPoolValidatorConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "toString()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "build()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "txPoolSimulationCheckP2pEnabled()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "txPoolSimulationCheckApiEnabled()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "maxTxCalldataSize()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "maxTxGasLimit()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "bundleDeniedAddresses()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "toBuilder()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "builder()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "deniedAddresses()".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of method "denyListPath()".
@param tag "bundleOverridingDenyListPath" does not match any actual type parameter of type "LineaTransactionPoolValidatorConfigurationBuilder".
@param tag "bundleOverridingDenyListPath" does not match any actual parameter of constructor "LineaTransactionPoolValidatorConfigurationBuilder()".

Check notice on line 24 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/config/LineaTransactionPoolValidatorConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "bundleDeniedAddresses" does not match any actual parameter of method "toString()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "build()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "txPoolSimulationCheckP2pEnabled()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "txPoolSimulationCheckApiEnabled()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "maxTxCalldataSize()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "maxTxGasLimit()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "toBuilder()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "bundleOverridingDenyListPath()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "builder()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "deniedAddresses()".
@param tag "bundleDeniedAddresses" does not match any actual parameter of method "denyListPath()".
@param tag "bundleDeniedAddresses" does not match any actual type parameter of type "LineaTransactionPoolValidatorConfigurationBuilder".
@param tag "bundleDeniedAddresses" does not match any actual parameter of constructor "LineaTransactionPoolValidatorConfigurationBuilder()".

Check notice on line 27 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/config/LineaTransactionPoolValidatorConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "toString()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "build()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "txPoolSimulationCheckP2pEnabled()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "maxTxCalldataSize()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "maxTxGasLimit()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "bundleDeniedAddresses()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "toBuilder()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "bundleOverridingDenyListPath()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "builder()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "deniedAddresses()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of method "denyListPath()".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual type parameter of type "LineaTransactionPoolValidatorConfigurationBuilder".
@param tag "txPoolSimulationCheckApiEnabled" does not match any actual parameter of constructor "LineaTransactionPoolValidatorConfigurationBuilder()".

Check notice on line 28 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/config/LineaTransactionPoolValidatorConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "toString()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "build()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "txPoolSimulationCheckApiEnabled()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "maxTxCalldataSize()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "maxTxGasLimit()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "bundleDeniedAddresses()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "toBuilder()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "bundleOverridingDenyListPath()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "builder()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "deniedAddresses()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of method "denyListPath()".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual type parameter of type "LineaTransactionPoolValidatorConfigurationBuilder".
@param tag "txPoolSimulationCheckP2pEnabled" does not match any actual parameter of constructor "LineaTransactionPoolValidatorConfigurationBuilder()".

Check notice on line 135 in besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorFactory.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note

The parameter 'unused' is never used.

Check failure on line 63 in coordinator/app/src/main/kotlin/linea/coordinator/config/v2/SignerConfig.kt

See this annotation in the file changed.

Code scanning / CodeQL

Equals or hashCode on arrays Error

The hashCode method on arrays only considers object identity and ignores array contents.

Check notice on line 224 in coordinator/app/src/main/kotlin/net/consensys/zkevm/coordinator/app/conflation/ConflationApp.kt

See this annotation in the file changed.

Code scanning / CodeQL

Unread local variable Note

Variable 'SimpleCompositeSafeFutureHandler compositeSafeFutureHandler' is never read.

Check notice on line 324 in coordinator/app/src/main/kotlin/net/consensys/zkevm/coordinator/app/conflation/ConflationApp.kt

See this annotation in the file changed.

Code scanning / CodeQL

Unread local variable Note

Variable 'SimpleCompositeSafeFutureHandler batchProofHandler' is never read.

Check failure on line 595 in coordinator/core/src/test/kotlin/net/consensys/zkevm/ethereum/coordination/aggregation/GlobalAggregationCalculatorTest.kt

See this annotation in the file changed.

Code scanning / CodeQL

Type mismatch on container access Error test

Actual argument type 'Long' is incompatible with expected argument type 'ULong'.

Check failure on line 139 in jvm-libs/linea/clients/interfaces/src/testFixtures/kotlin/linea/ethapi/FakeEthApiClient.kt

See this annotation in the file changed.

Code scanning / CodeQL

Type mismatch on container access Error test

Actual argument type 'Long' is incompatible with expected argument type 'ULong'.

Check failure on line 159 in jvm-libs/linea/clients/interfaces/src/testFixtures/kotlin/linea/ethapi/FakeEthApiClient.kt

See this annotation in the file changed.

Code scanning / CodeQL

Type mismatch on container access Error test

Actual argument type 'Long' is incompatible with expected argument type 'ULong'.

Check failure on line 24 in jvm-libs/linea/core/domain-models/src/main/kotlin/linea/domain/Transaction.kt

See this annotation in the file changed.

Code scanning / CodeQL

Overloaded compareTo Error

The parameter of compareTo should have type 'TransactionType' when implementing 'Comparable'.

Check warning on line 138 in testing-tools/app/src/main/java/net/consensys/zkevm/load/swagger/ArrayParameter.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
jsonElement
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 205 in testing-tools/app/src/main/java/net/consensys/zkevm/load/swagger/ArrayParameter.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
Parameter.toJson
Loading
; it is advisable to add an Override annotation.

Check warning on line 167 in testing-tools/app/src/main/java/net/consensys/zkevm/load/swagger/BatchMint.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning test

Variable
jsonElement
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 234 in testing-tools/app/src/main/java/net/consensys/zkevm/load/swagger/BatchMint.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
MethodAndParameter.toJson
Loading
; it is advisable to add an Override annotation.