set finalization section only onbce

Signed-off-by: F Bojarski <[email protected]>

Author: letypequividelespoubelles

arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java

@@ -645,10 +645,12 @@ public void traceContextExit(MessageFrame frame) {
       txStack
           .current()
           .setPreFinalisationValues(
-              leftOverGas, gasRefund, txStack.getAccumulativeGasUsedInBlockBeforeTxStart());
+              leftOverGas,
+              gasRefund,
+              txStack.getAccumulativeGasUsedInBlockBeforeTxStart(),
+              coinbaseWarmthAtTxEnd());
 
-      if (state.processingPhase() != TX_SKIP
-          && frame.getState() == MessageFrame.State.COMPLETED_SUCCESS) {
+      if (state.processingPhase() != TX_SKIP) {
         state.processingPhase(TX_FINL);
         new TxFinalizationSection(this);
       }
@@ -712,15 +714,6 @@ public void tracePostExecution(MessageFrame frame, Operation.OperationResult ope
     if (isExceptional() || !opCode().isCallOrCreate()) {
       this.unlatchStack(frame, currentSection);
     }
-
-    if (frame.getDepth() == 0 && (isExceptional() || opCode().isHalt())) {
-      state.processingPhase(TX_FINL);
-      setCoinbaseWarmthAtTxEnd();
-    }
-
-    if (frame.getDepth() == 0 && (isExceptional() || opCode() == REVERT)) {
-      new TxFinalizationSection(this);
-    }
   }
 
   public boolean isUnexceptional() {
@@ -1066,7 +1059,11 @@ protected TxnData setTxnData() {
     throw new IllegalStateException("must be implemented");
   }
 
-  protected void setInitializationSection(WorldView world) {}
+  protected void setInitializationSection(WorldView world) {
+    throw new IllegalStateException("must be implemented");
+  }
 
-  protected void setCoinbaseWarmthAtTxEnd() {}
+  protected boolean coinbaseWarmthAtTxEnd() {
+    throw new IllegalStateException("must be implemented");
+  }
 }

arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/LondonHub.java

@@ -47,11 +47,9 @@ protected void setInitializationSection(WorldView world) {
   }
 
   @Override
-  protected void setCoinbaseWarmthAtTxEnd() {
-    final boolean coinbaseWarmthAtTransactionEnd =
-        isExceptional() || opCode() == REVERT
-            ? txStack.current().isCoinbasePreWarmed()
-            : isAddressWarm(messageFrame(), coinbaseAddress());
-    this.txStack.current().coinbaseWarmAtTransactionEnd(coinbaseWarmthAtTransactionEnd);
+  protected boolean coinbaseWarmthAtTxEnd() {
+    return isExceptional() || opCode() == REVERT
+        ? txStack.current().isCoinbasePreWarmed()
+        : isAddressWarm(messageFrame(), coinbaseAddress());
   }
 }

arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/ShanghaiHub.java

@@ -44,9 +44,9 @@ protected void setInitializationSection(WorldView world) {
   }
 
   @Override
-  protected void setCoinbaseWarmthAtTxEnd() {
+  protected boolean coinbaseWarmthAtTxEnd() {
     // since EIP-3651 (Shanghai), the coinbase address is warm at the beginning of the transaction,
     // so obviously at the end.
-    this.txStack.current().coinbaseWarmAtTransactionEnd(true);
+    return true;
   }
 }

arithmetization/src/main/java/net/consensys/linea/zktracer/types/TransactionProcessingMetadata.java

@@ -164,7 +164,8 @@ public TransactionProcessingMetadata(
   public void setPreFinalisationValues(
       final long leftOverGas,
       final long refundCounterMax,
-      final long accumulatedGasUsedInBlockAtStartTx) {
+      final long accumulatedGasUsedInBlockAtStartTx,
+      final boolean coinbaseWarmAtTransactionEnd) {
 
     this.refundCounterMax = refundCounterMax;
     setLeftoverGas(leftOverGas);
@@ -173,6 +174,7 @@ public void setPreFinalisationValues(
     gasRefunded = computeRefunded();
     totalGasUsed = computeTotalGasUsed();
     accumulatedGasUsedInBlock = accumulatedGasUsedInBlockAtStartTx + totalGasUsed;
+    this.coinbaseWarmAtTransactionEnd = coinbaseWarmAtTransactionEnd;
   }
 
   public void completeLineaTransaction(